feat: Support new SCI assessment change functionality (#82)

* Updates to support assessment change functionality

* chore(deps): bump actions/setup-go in the dependencies group (#81)

Bumps the dependencies group with 1 update: [actions/setup-go](https://github.com/actions/setup-go).


Updates `actions/setup-go` from 5.3.0 to 5.4.0
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v5.3.0...v5.4.0)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Updated test data to be compatible with SCI v0.3+

Signed-off-by: Eddie Knight <knight@linux.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Eddie Knight <knight@linux.com>
Co-authored-by: Sarah Craddock <sarahcra@microsoft.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Eddie Knight <knight@linux.com>

Author: 4 people

go.mod

@@ -5,7 +5,7 @@ go 1.23.4
 require (
 	github.com/hashicorp/go-hclog v1.6.3
 	github.com/hashicorp/go-plugin v1.6.3
-	github.com/revanite-io/sci v0.1.9
+	github.com/revanite-io/sci v0.3.1
 	github.com/spf13/cobra v1.9.1
 	github.com/spf13/viper v1.19.0
 	gopkg.in/yaml.v3 v3.0.1

go.sum

@@ -57,8 +57,8 @@ github.com/pelletier/go-toml/v2 v2.2.2/go.mod h1:1t835xjRzz80PqgE6HHgN2JOsmgYu/h
 github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
 github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 h1:Jamvg5psRIccs7FGNTlIRMkT8wgtp5eCXdBlqhYGL6U=
 github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
-github.com/revanite-io/sci v0.1.9 h1:DnQ3NB1pqLhbRFYUM6CoA6hYbIJtRas1M6bJbsWL5VA=
-github.com/revanite-io/sci v0.1.9/go.mod h1:KNBMtb28TKYJ0aq6P0jX1XaIBYQdAziTvnI7uU2H+5Q=
+github.com/revanite-io/sci v0.3.1 h1:ggv0wyfFZm4jTTNUPvfho63eCJD0ux4hb6uMXvOJT74=
+github.com/revanite-io/sci v0.3.1/go.mod h1:KNBMtb28TKYJ0aq6P0jX1XaIBYQdAziTvnI7uU2H+5Q=
 github.com/rogpeppe/go-internal v1.9.0 h1:73kH8U+JUqXU8lRuOHeVHaa/SZPifC7BkcraZVejAe8=
 github.com/rogpeppe/go-internal v1.9.0/go.mod h1:WtVeX8xhTBvf0smdhujwtBcq4Qrzq/fJaraNFVN+nFs=
 github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=

pluginkit/evaluation_suite.go

@@ -17,7 +17,7 @@ import (
 
 type TestSet func() (result layer4.ControlEvaluation)
 
-// TestSuite is a struct that contains the results of all ControlEvaluations, orgainzed by name
+// TestSuite is a struct that contains the results of all ControlEvaluations, organized by name
 type EvaluationSuite struct {
 	Name            string        // Name is the name of the suite
 	Catalog_Id      string        // Catalog_Id associates this suite with an catalog

pluginkit/test_data.go

@@ -42,10 +42,10 @@ func passingEvaluation() (evaluation *layer4.ControlEvaluation) {
 		"fake-target-name",
 		"this change doesn't do anything",
 		nil,
-		func() (interface{}, error) {
+		func(interface{}) (interface{}, error) {
 			return nil, nil
 		},
-		func() error {
+		func(interface{}) error {
 			return nil
 		},
 	)
@@ -103,10 +103,10 @@ func corruptedEvaluation() (evaluation *layer4.ControlEvaluation) {
 		"fake-target-name",
 		"this change doesn't do anything",
 		nil,
-		func() (interface{}, error) {
-			return nil, fmt.Errorf("corrupted")
+		func(interface{}) (interface{}, error) {
+			return nil, nil
 		},
-		func() error {
+		func(interface{}) error {
 			return fmt.Errorf("corrupted")
 		},
 	)
@@ -147,9 +147,9 @@ func step_checkPayload(payloadData interface{}, _ map[string]*layer4.Change) (re
 	return layer4.Unknown, "Not implemented"
 }
 
-func step_Pass(_ interface{}, changes map[string]*layer4.Change) (result layer4.Result, message string) {
+func step_Pass(data interface{}, changes map[string]*layer4.Change) (result layer4.Result, message string) {
 	if changes != nil && changes["good-change"] != nil {
-		changes["good-change"].Apply()
+		changes["good-change"].Apply("target_name", "target_object", data)
 	}
 	return layer4.Passed, "This step always passes"
 }
@@ -166,8 +166,8 @@ func step_Unknown(_ interface{}, _ map[string]*layer4.Change) (result layer4.Res
 	return layer4.Unknown, "This step always returns unknown"
 }
 
-func step_Corrupted(_ interface{}, changes map[string]*layer4.Change) (result layer4.Result, message string) {
-	changes["corrupted-change"].Apply()
+func step_Corrupted(data interface{}, changes map[string]*layer4.Change) (result layer4.Result, message string) {
+	changes["corrupted-change"].Apply("target_name", "target_object", data)
 	return layer4.Unknown, "This step always returns unknown and applies a corrupted change"
 }
 

utils/utils.go

@@ -110,7 +110,7 @@ func WriteAllowed(path string) error {
 func GetExecutableName() string {
 	execAbsPath, err := os.Executable()
 	if err != nil {
-		log.Fatalf("[ERROR] Critical error ocurred while getting executable name")
+		log.Fatalf("[ERROR] Critical error occurred while getting executable name")
 	}
 
 	execName := filepath.Base(execAbsPath)