fix: address review feedback on binary rename

## What

Added explicit `binary: pvtr` to GoReleaser builds config so the
archive contains the correctly named binary. Changed the plugin
discovery filter from substring match to exact match so pvtr-* plugins
like pvtr-github-repo-scanner remain discoverable. Reverted the README
project structure directory name back to privateer/ since the repo is
not being renamed.

## Why

Copilot review correctly identified that GoReleaser would default the
binary name to the module name (privateer), causing Homebrew install to
fail. The substring filter would have hidden all pvtr-prefixed plugins
from env output.

## Notes

- The plugin filter now uses exact name matching (name == "pvtr" ||
  name == "privateer") instead of strings.Contains
- project_name remains privateer (archive naming unchanged), only the
  binary inside the archive is renamed to pvtr

Signed-off-by: jmeridth <jmeridth@gmail.com>

Author: jmeridth

.goreleaser.yaml

@@ -13,7 +13,8 @@ before:
     - go mod tidy
 
 builds:
-  - env:
+  - binary: pvtr
+    env:
       - CGO_ENABLED=0
     goos:
       - linux

README.md

@@ -91,7 +91,7 @@ make testcov
 ### Project Structure
 
 ```bash
-pvtr/
+privateer/
 ├── cmd/              # CLI commands (run, list, generate-plugin, etc.)
 ├── test/             # Test data and fixtures
 ├── build/            # Build scripts and CI configurations

cmd/env.go

@@ -58,7 +58,7 @@ func discoverPluginNames(pluginsDir string) string {
 	var names []string
 	for _, p := range pluginPaths {
 		name := filepath.Base(p)
-		if strings.Contains(name, "pvtr") || strings.Contains(name, "privateer") {
+		if name == "pvtr" || name == "privateer" {
 			continue
 		}
 		names = append(names, name)

cmd/env_test.go

@@ -120,11 +120,21 @@ func TestDiscoverPluginNames_FiltersPvtrAndPrivateer(t *testing.T) {
 
 	result := discoverPluginNames(tmpDir)
 
-	if strings.Contains(result, "pvtr") {
-		t.Errorf("expected pvtr binaries to be filtered out, got: %s", result)
+	// Exact-name binaries should be filtered out
+	for _, filtered := range []string{"pvtr", "privateer"} {
+		// Check the result doesn't contain the exact name as a standalone entry
+		for _, entry := range strings.Split(result, ", ") {
+			if entry == filtered {
+				t.Errorf("expected %q to be filtered out, got: %s", filtered, result)
+			}
+		}
+	}
+	// Prefixed plugin names should still be discoverable
+	if !strings.Contains(result, "pvtr-foo") {
+		t.Errorf("expected 'pvtr-foo' in result, got: %s", result)
 	}
-	if strings.Contains(result, "privateer") {
-		t.Errorf("expected privateer binaries to be filtered out, got: %s", result)
+	if !strings.Contains(result, "privateer-foo") {
+		t.Errorf("expected 'privateer-foo' in result, got: %s", result)
 	}
 	if !strings.Contains(result, "my-plugin") {
 		t.Errorf("expected 'my-plugin' in result, got: %s", result)