fix: suppress unresolvable dynamic import errors (#105)

Co-authored-by: Hiroki Osame <[email protected]>

Author: kravetsone

src/utils/get-rollup-configs.ts

@@ -138,7 +138,9 @@ const getConfig = {
 				json(),
 				esbuildTransform(esbuildConfig),
 				createRequire(),
-				dynamicImportVars(),
+				dynamicImportVars({
+					warnOnError: true,
+				}),
 				...(
 					options.minify
 						? [esbuildMinify(esbuildConfig)]

tests/fixtures.ts

@@ -257,3 +257,21 @@ export const fixtureDynamicImports: FileTree = {
 		},
 	},
 };
+
+// https://github.com/privatenumber/pkgroll/issues/104
+export const fixtureDynamicImportUnresolvable: FileTree = {
+	'package.json': createPackageJson({
+		main: './dist/dynamic-imports.js',
+	}),
+	src: {
+		'dynamic-imports.js': outdent`
+		function importModule(path) {
+			// who knows what will be imported here?
+			return import(path);
+		}
+
+		importModule('./too-dynamic.js');
+		`,
+		'too-dynamic.js': 'console.log(123)',
+	},
+};

tests/specs/builds/output-commonjs.ts

@@ -4,6 +4,7 @@ import { createFixture } from 'fs-fixture';
 import { pkgroll } from '../../utils.js';
 import {
 	packageFixture, createPackageJson, createTsconfigJson, fixtureDynamicImports,
+	fixtureDynamicImportUnresolvable,
 } from '../../fixtures.js';
 
 export default testSuite(({ describe }, nodePath: string) => {
@@ -204,5 +205,26 @@ export default testSuite(({ describe }, nodePath: string) => {
 			expect(files[1]).toMatch(/^bbb-/);
 			expect(files[2]).toMatch(/^ccc-/);
 		});
+
+		// https://github.com/privatenumber/pkgroll/issues/104
+		test('unresolvable dynamic import should not fail', async () => {
+			await using fixture = await createFixture({
+				...fixtureDynamicImportUnresolvable,
+				'package.json': createPackageJson({
+					exports: './dist/dynamic-imports.cjs',
+				}),
+			});
+
+			const pkgrollProcess = await pkgroll([], {
+				cwd: fixture.path,
+				nodePath,
+			});
+
+			expect(pkgrollProcess.exitCode).toBe(0);
+			expect(pkgrollProcess.stderr).toContain('[plugin rollup-plugin-dynamic-import-variables]');
+
+			const content = await fixture.readFile('dist/dynamic-imports.cjs', 'utf8');
+			expect(content).toMatch('import(');
+		});
 	});
 });

tests/specs/builds/output-module.ts

@@ -4,6 +4,7 @@ import { createFixture } from 'fs-fixture';
 import { pkgroll } from '../../utils.js';
 import {
 	packageFixture, createPackageJson, createTsconfigJson, fixtureDynamicImports,
+	fixtureDynamicImportUnresolvable,
 } from '../../fixtures.js';
 
 export default testSuite(({ describe }, nodePath: string) => {
@@ -272,5 +273,26 @@ export default testSuite(({ describe }, nodePath: string) => {
 			expect(files[1]).toMatch(/^bbb-/);
 			expect(files[2]).toMatch(/^ccc-/);
 		});
+
+		// https://github.com/privatenumber/pkgroll/issues/104
+		test('unresolvable dynamic import should not fail', async () => {
+			await using fixture = await createFixture({
+				...fixtureDynamicImportUnresolvable,
+				'package.json': createPackageJson({
+					exports: './dist/dynamic-imports.mjs',
+				}),
+			});
+
+			const pkgrollProcess = await pkgroll([], {
+				cwd: fixture.path,
+				nodePath,
+			});
+
+			expect(pkgrollProcess.exitCode).toBe(0);
+			expect(pkgrollProcess.stderr).toContain('[plugin rollup-plugin-dynamic-import-variables]');
+
+			const content = await fixture.readFile('dist/dynamic-imports.mjs', 'utf8');
+			expect(content).toMatch('import(');
+		});
 	});
 });