fix: prepend hashbang on nested binary in Windows (#114)

Co-authored-by: Robin <[email protected]>
Co-authored-by: Hiroki Osame <[email protected]>

Author: 3 people

src/rollup/get-rollup-configs.ts

@@ -120,7 +120,7 @@ export const getRollupConfigs = async (
 				entryFileNames: (chunk) => {
 					const realPath = fs.realpathSync.native(stripQuery(chunk.facadeModuleId!));
 					const relativePath = realPath.slice(sourceDirectoryPath.length);
-					const filePath = path.join(path.dirname(relativePath), chunk.name);
+					const filePath = path.posix.join(path.dirname(relativePath), chunk.name);
 					return filePath + distExtension;
 				},
 			};

tests/specs/builds/bin.ts

@@ -8,10 +8,10 @@ export default testSuite(({ describe }, nodePath: string) => {
 	describe('bin', ({ test }) => {
 		test('supports single path', async () => {
 			await using fixture = await createFixture({
-				...packageFixture(),
+				// Using a subpath tests that the paths are joined correctly on Windows
+				'src/subpath/bin.ts': 'console.log("Hello, world!");',
 				'package.json': createPackageJson({
-					bin: './dist/index.mjs',
-					exports: './dist/index.mjs',
+					bin: './dist/subpath/bin.mjs',
 				}),
 			});
 
@@ -24,12 +24,12 @@ export default testSuite(({ describe }, nodePath: string) => {
 			expect(pkgrollProcess.stderr).toBe('');
 
 			await test('is executable', async () => {
-				const content = await fixture.readFile('dist/index.mjs', 'utf8');
+				const content = await fixture.readFile('dist/subpath/bin.mjs', 'utf8');
 				expect(content).toMatch('#!/usr/bin/env node');
 
 				// File modes don't exist on Windows
 				if (process.platform !== 'win32') {
-					const stats = await fs.stat(`${fixture.path}/dist/index.mjs`);
+					const stats = await fs.stat(fixture.getPath('dist/subpath/bin.mjs'));
 					const unixFilePermissions = `0${(stats.mode & 0o777).toString(8)}`; // eslint-disable-line no-bitwise
 
 					expect(unixFilePermissions).toBe('0755');