feat: enhance env replacement with esbuild

Author: privatenumber

package.json

@@ -43,7 +43,6 @@
 		"@rollup/plugin-inject": "^5.0.5",
 		"@rollup/plugin-json": "^6.1.0",
 		"@rollup/plugin-node-resolve": "^16.0.0",
-		"@rollup/plugin-replace": "^6.0.2",
 		"@rollup/pluginutils": "^5.1.4",
 		"esbuild": "^0.24.2",
 		"magic-string": "^0.30.17",

pnpm-lock.yaml

@@ -4,7 +4,6 @@ import nodeResolve from '@rollup/plugin-node-resolve';
 import commonjs from '@rollup/plugin-commonjs';
 import json from '@rollup/plugin-json';
 import alias from '@rollup/plugin-alias';
-import replace from '@rollup/plugin-replace';
 import dynamicImportVars from '@rollup/plugin-dynamic-import-vars';
 import type { TsConfigResult } from 'get-tsconfig';
 import type { AliasMap } from '../../types.js';
@@ -27,6 +26,7 @@ export const getPkgConfig = (
 	const esbuildConfig: TransformOptions = {
 		target: options.target,
 		tsconfigRaw: tsconfig?.config,
+		define: env,
 	};
 
 	return {
@@ -47,20 +47,6 @@ export const getPkgConfig = (
 				extensions: ['.mjs', '.js', '.ts', '.jsx', '.tsx', '.json'],
 				exportConditions: options.exportCondition,
 			}),
-			...(
-				Object.keys(env).length > 0
-					? [replace({
-						preventAssignment: true,
-
-						/**
-                         * Seems this currently doesn't work:
-                         * https://github.com/rollup/plugins/pull/1084#discussion_r861447543
-                         */
-						objectGuards: true,
-						values: env,
-					})]
-					: []
-			),
 			stripHashbang(),
 			json(),
 			esbuildTransform(esbuildConfig),

src/rollup/configs/pkg.ts

@@ -6,7 +6,7 @@ export const esbuildTransform = (
 	options?: TransformOptions,
 ): Plugin => {
 	const filter = createFilter(
-		/\.([cm]?ts|[jt]sx)$/,
+		/\.([cm]?[jt]s|[jt]sx)$/,
 	);
 
 	return {

src/rollup/plugins/esbuild.ts

@@ -54,7 +54,10 @@ export const fixtureFiles = {
 	`,
 
 	'conditional-require.js': outdent`
-	if (process.env.NODE_ENV === 'production') {
+	if (
+		process.env.NODE_ENV === 'production'
+		|| process.env['NODE_ENV'] === 'production'
+	) {
 		console.log('production');
 		require('./cjs.cjs');
 	} else {

tests/fixtures.ts

@@ -23,7 +23,7 @@ export default testSuite(({ describe }, nodePath: string) => {
 
 			const content = await fixture.readFile('dist/conditional-require.js', 'utf8');
 			expect(content).toMatch('development');
-			expect(content).not.toMatch('2 ** 3');
+			expect(content).not.toMatch('production');
 		});
 	});
 });

tests/specs/builds/env.ts

@@ -224,7 +224,7 @@ export default testSuite(({ describe }, nodePath: string) => {
 			expect(pkgrollProcess.stderr).toBe('');
 
 			const content = await fixture.readFile('dist/conditional-require.mjs', 'utf8');
-			expect(content).toMatch('\tconsole.log(\'side effect\');');
+			expect(content).toMatch('\tconsole.log("side effect");');
 		});
 
 		test('require() & createRequire gets completely removed on conditional', async () => {