Skip to content

Commit b188701

Browse files
committed
Add Role, RoleBinding, ClusterRole, and ClusterRoleBinding in restore sequence.
Ensure the RBAC resources are restored before pods. The change help to avoid pod starting error when pod depends on the RBAC resources, e.g., prometheus operator check whether it has enough permission before launching controller, if prometheus operator pod starts before RBAC resources created, it will not launch controllers, and it will not retry. https://github.com/prometheus-operator/prometheus-operator/blob/f7f07bcdfb415aea4c87c1fb0dafe00968ad5420/cmd/operator/main.go#L392-L400 Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
1 parent 9d79e48 commit b188701

2 files changed

Lines changed: 5 additions & 0 deletions

File tree

changelogs/CHANGELOG-1.17.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ https://velero.io/docs/v1.17/upgrade-to-1.17/
1616
* Track actual resource names for GenerateName in restore status (#9409, @shubham-pampattiwar)
1717
* Fix managed fields patch for resources using GenerateName (#9408, @shubham-pampattiwar)
1818
* don't copy securitycontext from first container if configmap found (#9394, @sseago)
19+
* Add Role, RoleBinding, ClusterRole, and ClusterRoleBinding in restore sequence. (#9479, @blackpiglet)
1920

2021

2122
## v1.17.1

pkg/cmd/server/config/config.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,11 @@ var (
113113
"datauploads.velero.io",
114114
"persistentvolumes",
115115
"persistentvolumeclaims",
116+
"clusterroles",
117+
"roles",
116118
"serviceaccounts",
119+
"clusterrolebindings",
120+
"rolebindings",
117121
"secrets",
118122
"configmaps",
119123
"limitranges",

0 commit comments

Comments
 (0)