- removed usage of RNG Crypto Provider and replaced with RandomNumberGenerator

Author: prjseal

PasswordGenerator/Password.cs

@@ -17,38 +17,38 @@ public class Password : IPassword
         private const bool DefaultIncludeUppercase = true;
         private const bool DefaultIncludeNumeric = true;
         private const bool DefaultIncludeSpecial = true;
-        private static RNGCryptoServiceProvider _rng;
+        private static RandomNumberGenerator _rng;
 
         public Password()
         {
             Settings = new PasswordSettings(DefaultIncludeLowercase, DefaultIncludeUppercase,
                 DefaultIncludeNumeric, DefaultIncludeSpecial, DefaultPasswordLength, DefaultMaxPasswordAttempts,
                 true);
 
-            _rng = new RNGCryptoServiceProvider();
+            _rng = RandomNumberGenerator.Create();
         }
 
         public Password(IPasswordSettings settings)
         {
             Settings = settings;
 
-            _rng = new RNGCryptoServiceProvider();
+            _rng = RandomNumberGenerator.Create();
         }
 
         public Password(int passwordLength)
         {
             Settings = new PasswordSettings(DefaultIncludeLowercase, DefaultIncludeUppercase,
                 DefaultIncludeNumeric, DefaultIncludeSpecial, passwordLength, DefaultMaxPasswordAttempts, true);
-            
-            _rng = new RNGCryptoServiceProvider();
+
+            _rng = RandomNumberGenerator.Create();
         }
 
         public Password(bool includeLowercase, bool includeUppercase, bool includeNumeric, bool includeSpecial)
         {
             Settings = new PasswordSettings(includeLowercase, includeUppercase, includeNumeric,
                 includeSpecial, DefaultPasswordLength, DefaultMaxPasswordAttempts, false);
 
-            _rng = new RNGCryptoServiceProvider();
+            _rng = RandomNumberGenerator.Create();
         }
 
         public Password(bool includeLowercase, bool includeUppercase, bool includeNumeric, bool includeSpecial,
@@ -57,7 +57,7 @@ public Password(bool includeLowercase, bool includeUppercase, bool includeNumeri
             Settings = new PasswordSettings(includeLowercase, includeUppercase, includeNumeric,
                 includeSpecial, passwordLength, DefaultMaxPasswordAttempts, false);
 
-            _rng = new RNGCryptoServiceProvider();
+            _rng = RandomNumberGenerator.Create();
         }
 
         public Password(bool includeLowercase, bool includeUppercase, bool includeNumeric, bool includeSpecial,
@@ -66,7 +66,7 @@ public Password(bool includeLowercase, bool includeUppercase, bool includeNumeri
             Settings = new PasswordSettings(includeLowercase, includeUppercase, includeNumeric,
                 includeSpecial, passwordLength, maximumAttempts, false);
 
-            _rng = new RNGCryptoServiceProvider();
+            _rng = RandomNumberGenerator.Create();
         }
 
         public IPasswordSettings Settings { get; set; }

PasswordGenerator/PasswordGenerator.csproj

@@ -2,28 +2,27 @@
 
     <PropertyGroup>
         <TargetFramework>netstandard2.0</TargetFramework>
-        <PackageVersion>2.0.2</PackageVersion>
+        <PackageVersion>2.1.0</PackageVersion>
         <Title>PasswordGenerator</Title>
         <Authors>Paul Seal</Authors>
-        <Description>- Fixed bug with methods that use bool and int parameters for the Password class
+        <Description>- Removed usage of RNG Crypto Provider and used Random Number Generator
+- Fixed bug with methods that use bool and int parameters for the Password class
 - Removed usage of Random and replace it with a method which uses RngCrytopServiceProvider</Description>
-        <Copyright>Copyright 2019</Copyright>
+        <Copyright>Copyright 2022</Copyright>
         <PackageProjectUrl>https://github.com/prjseal/PasswordGenerator/</PackageProjectUrl>
-        <PackageLicenseUrl>https://github.com/prjseal/PasswordGenerator/blob/master/License.md</PackageLicenseUrl>
         <PackageIconUrl>https://github.com/prjseal/PasswordGenerator/blob/master/passwordgeneratorlogo.png?raw=true</PackageIconUrl>
         <RepositoryUrl>https://github.com/prjseal/PasswordGenerator/</RepositoryUrl>
         <RepositoryType>Git</RepositoryType>
-        <PackageTags>Password,Generator,OWASP,Security,Random,Special,Characters,.net,framework,standard,core,dotnet,dotnetcore,Rng,Crypto,RNGCryptoServiceProvider</PackageTags>
-        <PackageReleaseNotes>Compatible with .NET Core, .NET Framework and .NET Standard
+        <PackageTags>Password,Generator,OWASP,Security,Random,Special,Characters,.net,framework,standard,core,dotnet,dotnetcore,Rng,Random,Number,Generator</PackageTags>
+        <PackageReleaseNotes>Removed usage of RNG Crypto Provider
+		Compatible with .NET Core, .NET Framework and .NET Standard
 Added ability to get a group of passwords in one call</PackageReleaseNotes>
         <GeneratePackageOnBuild>false</GeneratePackageOnBuild>
-        <Version>2.0.5</Version>
-        <AssemblyVersion>2.0.5.0</AssemblyVersion>
-        <FileVersion>2.0.5.0</FileVersion>
+        <Version>2.1.0</Version>
+        <AssemblyVersion>2.1.0.0</AssemblyVersion>
+        <FileVersion>2.1.0.0</FileVersion>
+		<RepositoryType>Git</RepositoryType>
+		<PackageLicenseExpression>MIT</PackageLicenseExpression>
     </PropertyGroup>
 
-    <ItemGroup>
-      <PackageReference Include="NuGet.Build" Version="2.12.1" />
-    </ItemGroup>
-
 </Project>