revert(cross-validation reporter): Remove timing_normalized plot (#1055)

augustebaum · web-flow · commit 29d3689920a7 · 2025-01-08T15:41:28.000+01:00
Closes #1043
diff --git a/examples/getting_started/plot_quick_start.py b/examples/getting_started/plot_quick_start.py
@@ -42,9 +42,6 @@
 # %%
 reporter.plots.scores
 
-# %%
-reporter.plots.timing_normalized
-
 # %%
 # Finally, from your shell (in the same directory), start the UI:
 #
diff --git a/skore/src/skore/item/cross_validation_item.py b/skore/src/skore/item/cross_validation_item.py
@@ -344,7 +344,6 @@ def factory(cls, reporter: CrossValidationReporter) -> CrossValidationItem:
         humanized_plot_names = {
             "scores": "Scores",
             "timing": "Timings",
-            "timing_normalized": "Normalized timings",
         }
         plots_bytes = {
             humanized_plot_names[plot_name]: (
diff --git a/skore/src/skore/sklearn/cross_validation/cross_validation_reporter.py b/skore/src/skore/sklearn/cross_validation/cross_validation_reporter.py
@@ -16,7 +16,6 @@
     _strip_cv_results_scores,
 )
 from .plots.compare_scores_plot import plot_cross_validation_compare_scores
-from .plots.timing_normalized_plot import plot_cross_validation_timing_normalized
 from .plots.timing_plot import plot_cross_validation_timing
 
 
@@ -26,7 +25,6 @@ class CrossValidationPlots:
 
     scores: plotly.graph_objects.Figure
     timing: plotly.graph_objects.Figure
-    timing_normalized: plotly.graph_objects.Figure
 
 
 class CrossValidationReporter:
@@ -189,5 +187,4 @@ def plots(self) -> CrossValidationPlots:
         return CrossValidationPlots(
             scores=plot_cross_validation_compare_scores(self._cv_results),
             timing=plot_cross_validation_timing(self._cv_results),
-            timing_normalized=plot_cross_validation_timing_normalized(self._cv_results),
         )
diff --git a/skore/src/skore/sklearn/cross_validation/plots/timing_normalized_plot.py b/skore/src/skore/sklearn/cross_validation/plots/timing_normalized_plot.py
diff --git a/skore/tests/unit/item/test_cross_validation_item.py b/skore/tests/unit/item/test_cross_validation_item.py
@@ -37,7 +37,6 @@ class FakeCrossValidationReporter(CrossValidationReporter):
     plots = CrossValidationPlots(
         scores=plotly.graph_objects.Figure(),
         timing=plotly.graph_objects.Figure(),
-        timing_normalized=plotly.graph_objects.Figure(),
     )
     cv = StratifiedKFold(n_splits=5)
 
@@ -59,7 +58,6 @@ class FakeCrossValidationReporterNoGetParams(CrossValidationReporter):
     plots = CrossValidationPlots(
         scores=plotly.graph_objects.Figure(),
         timing=plotly.graph_objects.Figure(),
-        timing_normalized=plotly.graph_objects.Figure(),
     )
     cv = StratifiedKFold(n_splits=5)
 

Original file line number	Diff line number	Diff line change
`@@ -42,9 +42,6 @@`
`42`	`42`	`# %%`
`43`	`43`	`reporter.plots.scores`
`44`	`44`
`45`		`-# %%`
`46`		`-reporter.plots.timing_normalized`
`47`		`-`
`48`	`45`	`# %%`
`49`	`46`	`# Finally, from your shell (in the same directory), start the UI:`
`50`	`47`	`#`
Original file line number	Diff line number	Diff line change
`@@ -344,7 +344,6 @@ def factory(cls, reporter: CrossValidationReporter) -> CrossValidationItem:`
`344`	`344`	`humanized_plot_names = {`
`345`	`345`	`"scores": "Scores",`
`346`	`346`	`"timing": "Timings",`
`347`		`- "timing_normalized": "Normalized timings",`
`348`	`347`	`}`
`349`	`348`	`plots_bytes = {`
`350`	`349`	`humanized_plot_names[plot_name]: (`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,6 @@ class FakeCrossValidationReporter(CrossValidationReporter):`
`37`	`37`	`plots = CrossValidationPlots(`
`38`	`38`	`scores=plotly.graph_objects.Figure(),`
`39`	`39`	`timing=plotly.graph_objects.Figure(),`
`40`		`- timing_normalized=plotly.graph_objects.Figure(),`
`41`	`40`	`)`
`42`	`41`	`cv = StratifiedKFold(n_splits=5)`
`43`	`42`
`@@ -59,7 +58,6 @@ class FakeCrossValidationReporterNoGetParams(CrossValidationReporter):`
`59`	`58`	`plots = CrossValidationPlots(`
`60`	`59`	`scores=plotly.graph_objects.Figure(),`
`61`	`60`	`timing=plotly.graph_objects.Figure(),`
`62`		`- timing_normalized=plotly.graph_objects.Figure(),`
`63`	`61`	`)`
`64`	`62`	`cv = StratifiedKFold(n_splits=5)`
`65`	`63`