chore: Remove some unnecessary for loops in some unit tests (#1897)

closes #1853

Author: smazoyer

skore/tests/unit/sklearn/plot/prediction_error/test_comparison_cross_validation.py

@@ -142,15 +142,15 @@ def test_constructor(regression_data_no_split):
     display = report.metrics.prediction_error()
 
     index_columns = ["estimator_name", "split_index"]
-    for df in [display.prediction_error]:
-        assert all(col in df.columns for col in index_columns)
-        assert df.query("estimator_name == 'estimator_1'")[
-            "split_index"
-        ].unique().tolist() == list(range(cv))
-        assert df.query("estimator_name == 'estimator_2'")[
-            "split_index"
-        ].unique().tolist() == list(range(cv + 1))
-        assert df["estimator_name"].unique().tolist() == report.report_names_
+    df = display.prediction_error
+    assert all(col in df.columns for col in index_columns)
+    assert df.query("estimator_name == 'estimator_1'")[
+        "split_index"
+    ].unique().tolist() == list(range(cv))
+    assert df.query("estimator_name == 'estimator_2'")[
+        "split_index"
+    ].unique().tolist() == list(range(cv + 1))
+    assert df["estimator_name"].unique().tolist() == report.report_names_
 
 
 def test_frame(report):

skore/tests/unit/sklearn/plot/prediction_error/test_comparison_estimator.py

@@ -273,7 +273,7 @@ def test_constructor(regression_data):
     display = report.metrics.prediction_error()
 
     index_columns = ["estimator_name", "split_index"]
-    for df in [display.prediction_error]:
-        assert all(col in df.columns for col in index_columns)
-        assert df["estimator_name"].unique().tolist() == report.report_names_
-        assert df["split_index"].isnull().all()
+    df = display.prediction_error
+    assert all(col in df.columns for col in index_columns)
+    assert df["estimator_name"].unique().tolist() == report.report_names_
+    assert df["split_index"].isnull().all()

skore/tests/unit/sklearn/plot/prediction_error/test_cross_validation.py

@@ -172,7 +172,7 @@ def test_constructor(regression_data_no_split):
     display = report.metrics.prediction_error()
 
     index_columns = ["estimator_name", "split_index"]
-    for df in [display.prediction_error]:
-        assert all(col in df.columns for col in index_columns)
-        assert df["estimator_name"].unique() == report.estimator_name_
-        assert df["split_index"].unique().tolist() == list(range(cv))
+    df = display.prediction_error
+    assert all(col in df.columns for col in index_columns)
+    assert df["estimator_name"].unique() == report.estimator_name_
+    assert df["split_index"].unique().tolist() == list(range(cv))

skore/tests/unit/sklearn/plot/prediction_error/test_estimator.py

@@ -285,10 +285,10 @@ def test_constructor(regression_data):
     display = report.metrics.prediction_error()
 
     index_columns = ["estimator_name", "split_index"]
-    for df in [display.prediction_error]:
-        assert all(col in df.columns for col in index_columns)
-        assert df["estimator_name"].unique() == report.estimator_name_
-        assert df["split_index"].isnull().all()
-        np.testing.assert_allclose(df["y_true"], y_test)
-        np.testing.assert_allclose(df["y_pred"], estimator.predict(X_test))
-        np.testing.assert_allclose(df["residuals"], y_test - estimator.predict(X_test))
+    df = display.prediction_error
+    assert all(col in df.columns for col in index_columns)
+    assert df["estimator_name"].unique() == report.estimator_name_
+    assert df["split_index"].isnull().all()
+    np.testing.assert_allclose(df["y_true"], y_test)
+    np.testing.assert_allclose(df["y_pred"], estimator.predict(X_test))
+    np.testing.assert_allclose(df["residuals"], y_test - estimator.predict(X_test))