fix(skore-hub-project): Remove adherence to skore for type checking (#2018)

Fixes conda-forge/skore-hub-project-feedstock#4.

Author: thomass-dev

skore-hub-project/src/skore_hub_project/artefact/artefact.py

@@ -7,10 +7,10 @@
 from typing import Any
 
 from pydantic import BaseModel, ConfigDict, Field, computed_field
-from skore import CrossValidationReport, EstimatorReport
 
 from skore_hub_project import Project
 from skore_hub_project.artefact.upload import upload
+from skore_hub_project.protocol import CrossValidationReport, EstimatorReport
 
 
 class Artefact(ABC, BaseModel):

skore-hub-project/src/skore_hub_project/media/data.py

@@ -6,7 +6,8 @@
 from typing import Literal
 
 from pydantic import Field, computed_field
-from skore import EstimatorReport
+
+from skore_hub_project.protocol import EstimatorReport
 
 from .media import Media, Representation
 

skore-hub-project/src/skore_hub_project/media/feature_importance.py

@@ -7,7 +7,8 @@
 
 from pandas import DataFrame
 from pydantic import Field, computed_field
-from skore import CrossValidationReport, EstimatorReport
+
+from skore_hub_project.protocol import CrossValidationReport, EstimatorReport
 
 from .media import Media, Representation
 

skore-hub-project/src/skore_hub_project/media/model.py

@@ -4,7 +4,8 @@
 from typing import Literal
 
 from pydantic import Field, computed_field
-from skore import CrossValidationReport, EstimatorReport
+
+from skore_hub_project.protocol import CrossValidationReport, EstimatorReport
 
 from .media import Media, Representation
 
@@ -22,5 +23,5 @@ def representation(self) -> Representation:  # noqa: D102
 
         return Representation(
             media_type="text/html",
-            value=sklearn.utils.estimator_html_repr(self.report.estimator_),
+            value=sklearn.utils.estimator_html_repr(self.report.estimator),
         )

skore-hub-project/src/skore_hub_project/media/performance.py

@@ -8,7 +8,8 @@
 
 from matplotlib import pyplot as plt
 from pydantic import Field, computed_field
-from skore import CrossValidationReport, EstimatorReport
+
+from skore_hub_project.protocol import CrossValidationReport, EstimatorReport
 
 from .media import Media, Representation
 

skore-hub-project/src/skore_hub_project/metric/metric.py

@@ -10,7 +10,8 @@
 from typing import Any, ClassVar, Literal, cast
 
 from pydantic import BaseModel, ConfigDict, Field, computed_field
-from skore import CrossValidationReport, EstimatorReport
+
+from skore_hub_project.protocol import CrossValidationReport, EstimatorReport
 
 
 def cast_to_float(value: Any) -> float | None:

skore-hub-project/src/skore_hub_project/metric/timing.py

@@ -7,7 +7,8 @@
 
 from pandas import DataFrame, Series
 from pydantic import Field, computed_field
-from skore import CrossValidationReport, EstimatorReport
+
+from skore_hub_project.protocol import CrossValidationReport, EstimatorReport
 
 from .metric import Metric, cast_to_float
 

skore-hub-project/src/skore_hub_project/project/project.py

@@ -9,9 +9,9 @@
 from typing import TYPE_CHECKING
 
 import joblib
-from skore import CrossValidationReport, EstimatorReport
 
 from skore_hub_project.client.client import Client, HTTPStatusError, HUBClient
+from skore_hub_project.protocol import CrossValidationReport, EstimatorReport
 
 if TYPE_CHECKING:
     from typing import TypedDict

skore-hub-project/src/skore_hub_project/protocol.py

@@ -0,0 +1,36 @@
+"""Protocols definition used to remove adherence to ``skore`` for type checking."""
+
+from typing import Any, Protocol, runtime_checkable
+
+
+@runtime_checkable
+class EstimatorReport(Protocol):
+    """Protocol equivalent to ``skore.EstimatorReport``."""
+
+    _cache: Any
+    metrics: Any
+    data: Any
+    ml_task: Any
+    estimator: Any
+    estimator_name_: Any
+    X_train: Any
+    y_train: Any
+    X_test: Any
+    y_test: Any
+    fit: Any
+
+
+@runtime_checkable
+class CrossValidationReport(Protocol):
+    """Protocol equivalent to ``skore.CrossValidationReport``."""
+
+    _cache: Any
+    metrics: Any
+    estimator_reports_: Any
+    ml_task: Any
+    estimator: Any
+    estimator_name_: Any
+    X: Any
+    y: Any
+    splitter: Any
+    split_indices: Any

skore-hub-project/src/skore_hub_project/report/cross_validation_report.py

@@ -7,7 +7,6 @@
 from pydantic import Field, computed_field
 from sklearn.model_selection import BaseCrossValidator
 from sklearn.model_selection._split import _CVIterableWrapper
-from skore import CrossValidationReport
 
 from skore_hub_project.artefact import CrossValidationReportArtefact
 from skore_hub_project.media import (
@@ -55,6 +54,7 @@
     RocAucTrainStd,
 )
 from skore_hub_project.metric.metric import Metric
+from skore_hub_project.protocol import CrossValidationReport
 from skore_hub_project.report.estimator_report import EstimatorReportPayload
 from skore_hub_project.report.report import ReportPayload