chore(skore-hub-project): Fix typings

Author: thomass-dev

skore-hub-project/pyproject.toml

@@ -88,5 +88,15 @@ convention = "numpy"
 "tests/*" = ["D"]
 
 [tool.mypy]
+exclude = ["hatch/", "tests/"]
+
+[[tool.mypy.overrides]]
+follow_untyped_imports = true
+module = ["skore.*"]
+
+[[tool.mypy.overrides]]
 ignore_missing_imports = true
-exclude = ["hatch/*", "tests/*"]
+module = [
+  "joblib.*",
+  "sklearn.*",
+]

skore-hub-project/src/skore_hub_project/artifact/artifact.py

@@ -32,7 +32,7 @@ class Artifact(BaseModel, ABC):
     model_config = ConfigDict(frozen=True, arbitrary_types_allowed=True)
 
     project: Project = Field(repr=False, exclude=True)
-    content_type: str
+    content_type: str = Field(init=False)
 
     @abstractmethod
     def content_to_upload(self) -> Content | AbstractContextManager[Content]:

skore-hub-project/src/skore_hub_project/artifact/media/data.py

@@ -2,15 +2,14 @@
 
 from typing import Literal
 
-from pydantic import Field
-
 from skore_hub_project import switch_mpl_backend
-from skore_hub_project.artifact.media.media import Media
+from skore_hub_project.artifact.media.media import Media, Report
 from skore_hub_project.protocol import EstimatorReport
 
 
-class TableReport(Media):  # noqa: D101
+class TableReport(Media[Report]):  # noqa: D101
     name: Literal["table_report"] = "table_report"
+    data_source: Literal["train", "test"] | None = None
     content_type: Literal["application/vnd.skrub.table-report.v1+json"] = (
         "application/vnd.skrub.table-report.v1+json"
     )
@@ -41,11 +40,9 @@ def content_to_upload(self) -> bytes:  # noqa: D102
         )
 
 
-class TableReportTrain(TableReport):  # noqa: D101
-    report: EstimatorReport = Field(repr=False, exclude=True)
+class TableReportTrain(TableReport[EstimatorReport]):  # noqa: D101
     data_source: Literal["train"] = "train"
 
 
-class TableReportTest(TableReport):  # noqa: D101
-    report: EstimatorReport = Field(repr=False, exclude=True)
+class TableReportTest(TableReport[EstimatorReport]):  # noqa: D101
     data_source: Literal["test"] = "test"

skore-hub-project/src/skore_hub_project/artifact/media/feature_importance.py

@@ -5,13 +5,11 @@
 from functools import reduce
 from typing import ClassVar, Literal, cast
 
-from pydantic import Field
-
-from skore_hub_project.artifact.media.media import Media
+from skore_hub_project.artifact.media.media import Media, Report
 from skore_hub_project.protocol import EstimatorReport
 
 
-class FeatureImportance(Media, ABC):  # noqa: D101
+class FeatureImportance(Media[Report], ABC):  # noqa: D101
     accessor: ClassVar[str]
     content_type: Literal["application/vnd.dataframe"] = "application/vnd.dataframe"
 
@@ -41,8 +39,7 @@ def content_to_upload(self) -> bytes | None:  # noqa: D102
         )
 
 
-class Permutation(FeatureImportance, ABC):  # noqa: D101
-    report: EstimatorReport = Field(repr=False, exclude=True)
+class Permutation(FeatureImportance[EstimatorReport], ABC):  # noqa: D101
     accessor: ClassVar[str] = "feature_importance.permutation"
     name: Literal["permutation"] = "permutation"
 
@@ -55,12 +52,13 @@ class PermutationTest(Permutation):  # noqa: D101
     data_source: Literal["test"] = "test"
 
 
-class MeanDecreaseImpurity(FeatureImportance):  # noqa: D101
-    report: EstimatorReport = Field(repr=False, exclude=True)
+class MeanDecreaseImpurity(FeatureImportance[EstimatorReport]):  # noqa: D101
     accessor: ClassVar[str] = "feature_importance.mean_decrease_impurity"
     name: Literal["mean_decrease_impurity"] = "mean_decrease_impurity"
+    data_source: None = None
 
 
 class Coefficients(FeatureImportance):  # noqa: D101
     accessor: ClassVar[str] = "feature_importance.coefficients"
     name: Literal["coefficients"] = "coefficients"
+    data_source: None = None

skore-hub-project/src/skore_hub_project/artifact/media/media.py

@@ -1,12 +1,17 @@
 """Class definition of the payload used to associate a media with the report."""
 
+from abc import ABC
+from typing import Generic, TypeVar
+
 from pydantic import Field
 
 from skore_hub_project.artifact.artifact import Artifact
 from skore_hub_project.protocol import CrossValidationReport, EstimatorReport
 
+Report = TypeVar("Report", bound=(EstimatorReport | CrossValidationReport))
+
 
-class Media(Artifact):
+class Media(Artifact, Generic[Report], ABC):
     """
     Payload used to associate a media with the report.
 
@@ -17,13 +22,13 @@ class Media(Artifact):
     content_type : str
         The content-type of the artifact content.
     report : EstimatorReport | CrossValidationReport
-        The report to pickled.
+        The report on which compute the media.
     name : str
         The name of the media.
     data_source : str | None
         The source of the data used to generate the media.
     """
 
-    report: EstimatorReport | CrossValidationReport = Field(repr=False, exclude=True)
-    name: str
-    data_source: str | None = None
+    report: Report = Field(repr=False, exclude=True)
+    name: str = Field(init=False)
+    data_source: str | None = Field(init=False)

skore-hub-project/src/skore_hub_project/artifact/media/model.py

@@ -7,6 +7,7 @@
 
 class EstimatorHtmlRepr(Media):  # noqa: D101
     name: Literal["estimator_html_repr"] = "estimator_html_repr"
+    data_source: None = None
     content_type: Literal["text/html"] = "text/html"
 
     def content_to_upload(self) -> str:  # noqa: D102

skore-hub-project/src/skore_hub_project/client/api.py

@@ -3,7 +3,7 @@
 from datetime import datetime
 from time import sleep
 
-from httpx import HTTPError, TimeoutException
+from httpx import HTTPStatusError, TimeoutException
 
 
 def get_oauth_device_login(success_uri: str | None = None):
@@ -125,7 +125,7 @@ def get_oauth_device_code_probe(device_code: str, *, timeout=600):
         while True:
             try:
                 client.get(url, params=params)
-            except HTTPError as exc:
+            except HTTPStatusError as exc:
                 if exc.response.status_code != 400:
                     raise
 

skore-hub-project/src/skore_hub_project/client/client.py

@@ -58,7 +58,7 @@ class Client(HTTPXClient):
         )
     )
 
-    RETRYABLE_EXCEPTIONS: Final[tuple[HTTPError, ...]] = (
+    RETRYABLE_EXCEPTIONS: Final[tuple[type[HTTPError], ...]] = (
         TimeoutException,
         NetworkError,
         RemoteProtocolError,

skore-hub-project/src/skore_hub_project/metric/accuracy.py

@@ -12,6 +12,7 @@ class Accuracy(EstimatorReportMetric):  # noqa: D101
     name: Literal["accuracy"] = "accuracy"
     verbose_name: Literal["Accuracy"] = "Accuracy"
     greater_is_better: Literal[True] = True
+    position: None = None
 
 
 class AccuracyTrain(Accuracy):  # noqa: D101
@@ -28,6 +29,7 @@ class AccuracyMean(CrossValidationReportMetric):  # noqa: D101
     name: Literal["accuracy_mean"] = "accuracy_mean"
     verbose_name: Literal["Accuracy - MEAN"] = "Accuracy - MEAN"
     greater_is_better: Literal[True] = True
+    position: None = None
 
 
 class AccuracyTrainMean(AccuracyMean):  # noqa: D101
@@ -44,6 +46,7 @@ class AccuracyStd(CrossValidationReportMetric):  # noqa: D101
     name: Literal["accuracy_std"] = "accuracy_std"
     verbose_name: Literal["Accuracy - STD"] = "Accuracy - STD"
     greater_is_better: Literal[False] = False
+    position: None = None
 
 
 class AccuracyTrainStd(AccuracyStd):  # noqa: D101

skore-hub-project/src/skore_hub_project/metric/brier_score.py

@@ -12,6 +12,7 @@ class BrierScore(EstimatorReportMetric):  # noqa: D101
     name: Literal["brier_score"] = "brier_score"
     verbose_name: Literal["Brier score"] = "Brier score"
     greater_is_better: Literal[False] = False
+    position: None = None
 
 
 class BrierScoreTrain(BrierScore):  # noqa: D101
@@ -28,6 +29,7 @@ class BrierScoreMean(CrossValidationReportMetric):  # noqa: D101
     name: Literal["brier_score_mean"] = "brier_score_mean"
     verbose_name: Literal["Brier score - MEAN"] = "Brier score - MEAN"
     greater_is_better: Literal[False] = False
+    position: None = None
 
 
 class BrierScoreTrainMean(BrierScoreMean):  # noqa: D101
@@ -44,6 +46,7 @@ class BrierScoreStd(CrossValidationReportMetric):  # noqa: D101
     name: Literal["brier_score_std"] = "brier_score_std"
     verbose_name: Literal["Brier score - STD"] = "Brier score - STD"
     greater_is_better: Literal[False] = False
+    position: None = None
 
 
 class BrierScoreTrainStd(BrierScoreStd):  # noqa: D101