diff --git a/skore-ui/src/assets/styles/_variables.css b/skore-ui/src/assets/styles/_variables.css index 10a26d32d8..22fa25f068 100644 --- a/skore-ui/src/assets/styles/_variables.css +++ b/skore-ui/src/assets/styles/_variables.css @@ -75,6 +75,11 @@ body[data-vscode-theme-kind="vscode-dark"], /* shadow */ --color-shadow: rgb(0 0 0/58%); + + /* images */ + --image-not-found: url("../images/not-found-dark.png"); + --image-editor-placeholder: url("../images/editor-placeholder-dark.svg"); + --image-activity-feed-placeholder: url("../images/activity-feed-placeholder-dark.svg"); } body[data-jp-theme-light="true"], @@ -108,4 +113,9 @@ body[data-vscode-theme-kind="vscode-light"], /* shadow */ --color-shadow: rgb(0 0 0/19%); + + /* images */ + --image-not-found: url("../images/not-found-light.png"); + --image-editor-placeholder: url("../images/editor-placeholder-light.svg"); + --image-activity-feed-placeholder: url("../images/activity-feed-placeholder-light.svg"); } diff --git a/skore-ui/src/assets/styles/main.css b/skore-ui/src/assets/styles/main.css index f8624d1a2c..5d5bf0ac1e 100644 --- a/skore-ui/src/assets/styles/main.css +++ b/skore-ui/src/assets/styles/main.css @@ -15,3 +15,11 @@ background-color: var(--color-background-branding); } } + +.simplebar-inverted { + .simplebar-scrollbar { + &::before { + background-color: var(--color-text-tertiary); + } + } +} diff --git a/skore-ui/src/components/DropdownButtonItem.vue b/skore-ui/src/components/DropdownButtonItem.vue index 3c23739225..34e16daf3e 100644 --- a/skore-ui/src/components/DropdownButtonItem.vue +++ b/skore-ui/src/components/DropdownButtonItem.vue @@ -34,6 +34,7 @@ const props = withDefaults(defineProps(), { iconPosition: "le border: 0; border-bottom: 1px solid var(--color-stroke-background-primary); background-color: var(--color-background-primary); + color: var(--color-text-primary); cursor: pointer; text-align: left; white-space: nowrap; diff --git a/skore-ui/src/components/EditableListItem.vue b/skore-ui/src/components/EditableListItem.vue index ab0ee6cf6d..0b4834763c 100644 --- a/skore-ui/src/components/EditableListItem.vue +++ b/skore-ui/src/components/EditableListItem.vue @@ -128,9 +128,8 @@ onMounted(() => { transition: font-weight var(--animation-duration) var(--animation-easing); &[contenteditable="true"] { - background-color: var(--color-background-branding); - caret-color: var(--color-text-button-primary); - color: var(--color-text-button-primary); + caret-color: var(--color-text-branding); + color: var(--color-text-primary); cursor: text; } } diff --git a/skore-ui/src/components/ProjectViewCard.vue b/skore-ui/src/components/ProjectViewCard.vue index 68f891e481..924b6d552c 100644 --- a/skore-ui/src/components/ProjectViewCard.vue +++ b/skore-ui/src/components/ProjectViewCard.vue @@ -116,6 +116,7 @@ onBeforeUnmount(() => { & .titles { position: relative; padding-left: calc(var(--spacing-8) + 4px); + color: var(--color-text-primary); & .title { font-size: var(--font-size-sm); diff --git a/skore-ui/src/components/TreeAccordionItem.vue b/skore-ui/src/components/TreeAccordionItem.vue index 375d69f99f..6f9b8c2d82 100644 --- a/skore-ui/src/components/TreeAccordionItem.vue +++ b/skore-ui/src/components/TreeAccordionItem.vue @@ -169,6 +169,7 @@ onMounted(() => { & .text { border-radius: var(--radius-xs); + color: var(--color-text-primary); } &.has-children { @@ -191,12 +192,13 @@ onMounted(() => { border: none; margin: 0; background-color: transparent; + color: var(--color-text-secondary); cursor: pointer; font-size: var(--font-size-md); transition: color var(--animation-duration) var(--animation-easing); &:hover { - color: var(--color-primary); + color: var(--color-text-primary); } } } diff --git a/skore-ui/src/views/activity/ActivityFeedView.vue b/skore-ui/src/views/activity/ActivityFeedView.vue index ca7bddd8ab..444e78d520 100644 --- a/skore-ui/src/views/activity/ActivityFeedView.vue +++ b/skore-ui/src/views/activity/ActivityFeedView.vue @@ -129,6 +129,7 @@ onBeforeUnmount(() => { & .inner { padding-top: 189px; + background-image: var(--image-activity-feed-placeholder); background-position: center; background-repeat: no-repeat; background-size: 189px 180px; @@ -140,16 +141,4 @@ onBeforeUnmount(() => { } } } - -@media (prefers-color-scheme: light) { - .activity-feed .placeholder .inner { - background-image: url("../../assets/images/activity-feed-placeholder-light.svg"); - } -} - -@media (prefers-color-scheme: dark) { - .activity-feed .placeholder .inner { - background-image: url("../../assets/images/activity-feed-placeholder-dark.svg"); - } -} diff --git a/skore-ui/src/views/project/ProjectView.vue b/skore-ui/src/views/project/ProjectView.vue index 8dcb4bf3cb..83ecbc8f4f 100644 --- a/skore-ui/src/views/project/ProjectView.vue +++ b/skore-ui/src/views/project/ProjectView.vue @@ -122,20 +122,6 @@ onBeforeUnmount(() => {