Commit 40b6391
authored
Enable auto-rebuild in
Closes MET-41
## Summary of Changes
`scikit-build-core` has an `editable.rebuild` option, which can
automatically invoke CMake under the hood when we import from
`genmetaballs` to rebuild the C++ extension if needed. To use this
option, we need to turn off build isolation for our package so that
scikit build can use the right set of tools (see
scikit-build/scikit-build-core#1112 (comment)).
On the other hand, this also makes rebuilding a lot faster because Pixi
doesn't have to re-create a new isolated environment and build from
scratch.
See [`scikit-build-core`'s official doc on editable install for more
details](https://scikit-build-core.readthedocs.io/en/latest/configuration/index.html#editable-installs).
With this change, we shouldn't need to manually run `pixi reinstall
genmetaballs` anymore. Hopefully this will make our development
experience a bit smoother :).
## Test Plan
After enabling this option & run `pixi reinstall genmetaballs` one last
time just to make sure that the config is active. Then, I tried
modifying a couple of the C++ files, then run `pixi run test`
immediately after (without running `reinstall` manually), and the
changes are correctly reflected on the Python test results.scikit-build-core at import time (#27)1 parent 76458d2 commit 40b6391
3 files changed
+20
-14
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
50 | 55 | | |
51 | 56 | | |
52 | 57 | | |
53 | | - | |
| 58 | + | |
54 | 59 | | |
55 | 60 | | |
56 | 61 | | |
| |||
66 | 71 | | |
67 | 72 | | |
68 | 73 | | |
| 74 | + | |
69 | 75 | | |
70 | 76 | | |
71 | 77 | | |
| |||
86 | 92 | | |
87 | 93 | | |
88 | 94 | | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
96 | 102 | | |
97 | 103 | | |
98 | | - | |
99 | | - | |
| 104 | + | |
| 105 | + | |
100 | 106 | | |
101 | 107 | | |
102 | 108 | | |
103 | 109 | | |
104 | 110 | | |
105 | | - | |
| 111 | + | |
0 commit comments