Fix clippy lint, add tests for setup macro

Author: t-moe

.github/workflows/ci.yml

@@ -86,7 +86,7 @@ jobs:
         uses: Swatinem/rust-cache@v2.7.5
 
       - name: Run Compile tests
-        run: cd tests-build && cargo test
+        run: cd tests-build && cargo test -- --test-threads 1
 
   fmt:
     name: Rustfmt

macros/src/attributes/tests/codegen/export_sym.rs

@@ -46,7 +46,7 @@ pub(crate) fn export_sym(
             if ignore { "true" } else { "false" },
             if should_panic { "true" } else { "false" },
             if let Some(timeout) = timeout {
-                format!(",\"timeout\":{}", timeout)
+                format!(",\"timeout\":{timeout}")
             } else {
                 String::new()
             }

macros/src/attributes/tests/parse/items.rs

@@ -60,7 +60,7 @@ pub(crate) fn parse_item(mut f: ItemFn) -> Result<Func, syn::Error> {
             Err(e) => {
                 return Err(syn::Error::new(
                     attr.span(),
-                    format!("failed to parse `timeout` attribute. Must be of the form #[timeout(10)] where 10 is the timeout in seconds. Error: {}", e)
+                    format!("failed to parse `timeout` attribute. Must be of the form #[timeout(10)] where 10 is the timeout in seconds. Error: {e}")
                 ));
             }
         }

tests-build/cases/fail/duplicate_setup.rs

@@ -0,0 +1,31 @@
+/*
+```cargo
+[dependencies]
+embedded-test = { path = "../../.." }
+[lib]
+harness = false
+```
+ */
+
+#![no_std]
+#![no_main]
+
+#[cfg(test)]
+#[embedded_test::setup]
+fn setup() {}
+
+mod somewhere_else {
+    #[cfg(test)]
+    #[embedded_test::setup]
+    fn setup() {}
+}
+
+#[cfg(test)]
+#[embedded_test::tests]
+mod tests {
+
+    #[test]
+    fn ok() {
+        assert!(true);
+    }
+}

tests-build/cases/fail/duplicate_setup.stderr

@@ -0,0 +1 @@
+error: symbol `_embedded_test_setup` is already defined

tests-build/cases/pass/setup.rs

@@ -0,0 +1,30 @@
+/*
+```cargo
+[dependencies]
+embedded-test = { path = "../../.." }
+rtt-target = { version = "0.6.1", features = ["log"] }
+log = { version = "0.4.20" }
+esp-hal = { version = "0.23.1", features = ["esp32c6"] } # for critical section implementation
+[lib]
+harness = false
+```
+ */
+
+#![no_std]
+#![no_main]
+
+#[cfg(test)]
+#[embedded_test::setup]
+fn setup() {
+    rtt_target::rtt_init_log!();
+}
+
+#[cfg(test)]
+#[embedded_test::tests]
+mod tests {
+    use esp_hal::*; // needs to be in scope, to prevent linker error about missing `critical_section` implementation
+    #[test]
+    fn ok() {
+        log::info!("Hello world");
+    }
+}