pass strings by const reference and use find_last_not_of (#779)

* pass std::strings by const reference

* use std::string::find_last_not_of

Author: soyersoyer

src/minidexed.cpp

@@ -1968,9 +1968,9 @@ std::string CMiniDexed::GetNewPerformanceDefaultName(void)
 	return m_PerformanceConfig.GetNewPerformanceDefaultName();
 }
 
-void CMiniDexed::SetNewPerformanceName(std::string nName)
+void CMiniDexed::SetNewPerformanceName(const std::string &Name)
 {
-	m_PerformanceConfig.SetNewPerformanceName(nName);
+	m_PerformanceConfig.SetNewPerformanceName(Name);
 }
 
 bool CMiniDexed::IsValidPerformance(unsigned nID)
@@ -1983,7 +1983,7 @@ bool CMiniDexed::IsValidPerformanceBank(unsigned nBankID)
 	return m_PerformanceConfig.IsValidPerformanceBank(nBankID);
 }
 
-void CMiniDexed::SetVoiceName (std::string VoiceName, unsigned nTG)
+void CMiniDexed::SetVoiceName (const std::string &VoiceName, unsigned nTG)
 {
 	assert (nTG < CConfig::AllToneGenerators);
 	if (nTG >= m_nToneGenerators) return;  // Not an active TG

src/minidexed.h

@@ -164,8 +164,8 @@ class CMiniDexed
 	int GetParameter (TParameter Parameter);
 
 	std::string GetNewPerformanceDefaultName(void);
-	void SetNewPerformanceName(std::string nName);
-	void SetVoiceName (std::string VoiceName, unsigned nTG);
+	void SetNewPerformanceName(const std::string &Name);
+	void SetVoiceName (const std::string &VoiceName, unsigned nTG);
 	bool DeletePerformance(unsigned nID);
 	bool DoDeletePerformance(void);
 

src/performanceconfig.cpp

@@ -1095,17 +1095,9 @@ std::string CPerformanceConfig::GetNewPerformanceDefaultName(void)
 	return "Perf" + nIndex;
 }
 
-void CPerformanceConfig::SetNewPerformanceName(std::string nName)
+void CPerformanceConfig::SetNewPerformanceName(const std::string &Name)
 {
-	int  i = nName.length();
-	do
-	{
-		--i;
-	}
-	while (i>=0 && nName[i] == 32);
-	nName=nName.substr(0,i+1)  ;
-	
-	NewPerformanceName = nName;
+	NewPerformanceName = Name.substr(0, Name.find_last_not_of(' ') + 1);
 }
 
 bool CPerformanceConfig::DeletePerformance(unsigned nID)

src/performanceconfig.h

@@ -137,7 +137,7 @@ class CPerformanceConfig	// Performance configuration
 	bool CreateNewPerformanceFile(void);
 	bool GetInternalFolderOk(); 
 	std::string GetNewPerformanceDefaultName(void);
-	void SetNewPerformanceName(std::string nName);
+	void SetNewPerformanceName(const std::string &Name);
 	bool DeletePerformance(unsigned nID);
 	bool CheckFreePerformanceSlot(void);
 	std::string AddPerformanceBankDirName(unsigned nBankID);