Skip to content
This repository was archived by the owner on Jan 17, 2025. It is now read-only.
This repository was archived by the owner on Jan 17, 2025. It is now read-only.

[REFACTOR] Reorganize the CSS rules #72

@tbouffard

Description

@tbouffard

This particularly applies to Happy Path rules but review all css rules.

happy-path rules
There is no need to declare class by types. The CSS classname should always be the same and the CSS rule should required both the BPMN CSS classes and the specific classes. For intance bpmn-type-activity.happy-path

The from/to stroke are not needed in the animation if the grow keyframes (same values for from and to), if the value was correctly set in the CSS rule referencing this keyframes declaration

@keyframes grow {
from {
stroke-dashoffset: 100%;
stroke-dasharray: 100%;
stroke: var(--stroke);
stroke-width: var(--stroke-width);
fill: var(--fillStart);
}
to {
stroke-dashoffset: 0;
stroke: var(--stroke);
stroke-width: var(--stroke-width);
fill: var(--fillEnd);
}
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions