Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Submit Sketches to someone else's Collections. #2878

Conversation

vivekbopaliya
Copy link
Contributor

@vivekbopaliya vivekbopaliya commented Jan 11, 2024

Fixes #1117

Changes:

bandicam.2024-01-19.21-46-54-806.mp4

WORK FLOW:

  • The 'Send Request' option is visible only to non-owners of the collection.
  • Users can send sketch requests to any collection.
  • Collection owners receive and review incoming sketch requests.
  • Owners have the option to accept or reject each request.
  • If accepted, the sketch is added to the collection with the original sketch owner's name.
  • If rejected, the sketch is not added, and the request message is deleted.

WHAT'S HAPPENING UNDER THE HOOD:

  • Upon every sketch request, a new schema named 'Message' is created, containing fields such as Request receiver, 'request sender', 'message', 'ProjectID', and 'CollectionID'.
  • Both 'ProjectID' and 'CollectionID' are provided to the API as parameters.
  • All messages are fetched based on the 'Request receiver' name.
  • Each message includes the 'Request sender' name and the 'Collection' name.
  • Upon acceptance, the sketch is saved to the collection depending on the 'ProjectID' and 'CollectionID'.
  • All static words are retrieved directly from "translate.json" ensuring support for multiple languages.

PS:

  • This PR is still in development, any suggestions or inputs are welcomed and highly appreciated.
  • Currently awaiting finalized designs before proceeding to implement this feature on mobile devices.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@raclim
Copy link
Collaborator

raclim commented Jun 24, 2024

Thanks so much for your work on this!

Due to the amount of the changes here that have fallen out of date and some of the other features and fixes we'd like to prioritize at the moment (again, such as the privating sketches PR!), I'm going to close this pull request for now. I'm really sorry that we couldn't get this in at the moment, but please feel free to update and reopen this pull request in the future!

@raclim raclim closed this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submit sketches to someone else's collection
3 participants