Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After claiming size limit of 250MB storage, the Upload File button will be disable #2674

Closed
wants to merge 11 commits into from
Closed

After claiming size limit of 250MB storage, the Upload File button will be disable #2674

wants to merge 11 commits into from

Conversation

Swarnendu0123
Copy link
Contributor

@Swarnendu0123 Swarnendu0123 commented Nov 30, 2023 •
edited
Loading

Logic Implemented: If the currendSize >= sizeLimit then the Upload File button will be automatically disabled

Fixes #2080

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@Swarnendu0123 Swarnendu0123 changed the title After claiming size limit of 250MB the Upload File button will be disable After claiming size limit of 250MB storage, the Upload File button will be disable Nov 30, 2023
PiyushChandra17
PiyushChandra17 reviewed Dec 10, 2023
View reviewed changes
Copy link
Contributor

@PiyushChandra17 PiyushChandra17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely Done 👍

@Swarnendu0123
Copy link
Contributor Author

Nicely Done 👍

Thanks @PiyushChandra17 for your review

@Swarnendu0123
Copy link
Contributor Author

Swarnendu0123 commented Dec 19, 2023 •
edited
Loading

@lindapaiste @raclim Can you please review the PR? and give me your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiyushChandra17 PiyushChandra17 PiyushChandra17 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error message claiming size limit of 250MB reached
2 participants
@Swarnendu0123 @PiyushChandra17