Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conflicts in eslint package versions (#2219) #2220

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix conflicts in eslint package versions (#2219) #2220

wants to merge 4 commits into from
+1,516 −2,738

Conversation

lindapaiste
Copy link
Collaborator

@lindapaiste lindapaiste commented May 22, 2023 •
edited
Loading

Fixes #2219

Changes:

  • Update eslint-config-airbnb to the latest version.
  • Bump eslint from 7.31.0 to 7.32.0.
  • Turn off (set to 0) rules which I think that we don't want to keep.
  • Downgrade to a warning (set to 1) rules which I think that we should keep.
  • Fixed a few rule violations that we only had in one place, so I didn't think that they warranted separate PRs:
    • Deleted unreachable else branch in client/modules/IDE/pages/MobileIDEView.jsx (violated no-dupe-else-if)
    • Don't assign properties on imported object FileActions in client/modules/IDE/components/FileNode.jsx (violated no-import-assign)
    • Changed export { ConnectedFileNode as default }; to export default ConnectedFileNode; in client/modules/IDE/components/FileNode.jsx (violated no-restricted-exports)
    • Added some curly braces in client/modules/User/actions.js so that the inner function of the Promise doesn't return anything (violated no-promise-executor-return)
    • Changed if (module.hot) to if (import.meta.webpackHot) in client/store.js as recommended by webpack for strict ESM compliance. (violated import/no-import-module-exports) I had to roll this back due to issues with Jest.
    • Added missing prop types to RedirectToUser. (violated react/prop-types)

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

There are no linting errors but there are 64 warnings.

@lindapaiste lindapaiste marked this pull request as ready for review June 4, 2023 00:41
@raclim raclim added the Area: Dependencies Pull requests that update a dependency file label Nov 3, 2023
@lindapaiste
Copy link
Collaborator Author

@raclim if we want to fix the conflicts on this so that it can be merged just let me know. The import part is the .eslintrc and the two version bumps in the package.json. There may be conflicts (currently and in the future) regarding the rule violations which I chose to fix rather than adding exceptions for, as a lot of those mistakes have been cleaned up in other PRs.

@raclim raclim added this to the MINOR Release for 2.11.0 milestone Jan 8, 2024
@raclim
Copy link
Collaborator

raclim commented Jan 8, 2024

Thanks for raising this, that makes sense to me! I think I might push the next release date to Jan 16th to get a few more PRs in, so I'm going to add this to the current milestone.

@lindapaiste lindapaiste mentioned this pull request Feb 4, 2024
Closed
4 tasks
@raclim raclim removed this from the MINOR Release for 2.12.0 milestone Mar 8, 2024
@raclim raclim mentioned this pull request Nov 12, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot run npm install due to dependency conflicts in eslint packages
2 participants
@lindapaiste @raclim