Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented Lazy Loading in React Components #3420

Closed
wants to merge 2 commits into from
Closed

Implemented Lazy Loading in React Components #3420

wants to merge 2 commits into from

Conversation

shivasankaran18
Copy link

@shivasankaran18 shivasankaran18 commented Mar 25, 2025 •
edited
Loading

Fixes #3403

Changes:

  • Implemented lazy loading for React components using React.lazy() and Suspense.

  • Optimized initial load performance by loading components only when needed.

  • Updated React Router to support lazy-loaded pages, reducing JavaScript bundle size.

  • Wrapped lazy-loaded components with fallback loaders (spinners) for a smoother user experience.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome Welcome
Copy link

welcome bot commented Mar 25, 2025

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@shivasankaran18
Copy link
Author

@raclim could you review this PR

@raclim
Copy link
Collaborator

raclim commented Mar 28, 2025

Thanks for looking into this @shivasankaran18! Although implementing lazy loading can definitely offer benefits, this PR currently applies across all routes in the editor. That approach might not be ideal—especially for areas like IDEView, which is a central part of the editor that experiences a lot of engagement. Lazy loading it could lead to noticeable delays or layout shifts when navigating, which we’d ideally want to avoid.

It might be more effective to first take a step back and identify which parts of the editor would genuinely benefit from lazy loading before jumping into implementation. With that in mind, I'm going to close this PR for now. That said, please feel free to continue exploring this idea and reopen the PR after further discussion and refinement!

@raclim raclim closed this Mar 28, 2025
@shivasankaran18
Copy link
Author

yeah ok @raclim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Lazy Loading for React Components
2 participants
@shivasankaran18 @raclim