Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed linting from webpack #1736

Closed
wants to merge 1 commit into from

Conversation

MohdImran001
Copy link
Contributor

Fixes #625

Removed linting from Webpack. Now Webpack build is much faster than before. On my system, Webpack build with linting took 130540ms and Webpack build without linting took 57886ms. The build time has reduced by 60%.

Hey @catarak, please review this PR.

@catarak
Copy link
Member

catarak commented Jan 27, 2021

Your prettier config has added a lot of unnecessary changes here! I've been working on updating webpack packages and adding prettier and other infrastructure changes. After thinking about it, I think it makes sense to leave linting, even if it makes the webpack build slower, because it's helpful for finding bugs when you're writing code. I think adding prettier has made this process less frustrating.

Thank you so much for working on this though, I really appreciate the push to tackle some of these infrastructure issues.

@catarak catarak closed this Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make webpack build time faster
2 participants