Skip to content

Commit d0e6e41

Browse files
authored
Merge pull request #8964 from NalinDalal/main
Fix framebuffer texture size clamping using wrong pixel density
2 parents b96a732 + eb63e8d commit d0e6e41

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/webgl/p5.Framebuffer.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ class Framebuffer {
9393
this.density = settings.density || this.renderer._pixelDensity;
9494
if (settings.width && settings.height) {
9595
const dimensions =
96-
this.renderer._adjustDimensions(settings.width, settings.height);
96+
this.renderer._adjustDimensions(settings.width, settings.height, this.density);
9797
this.width = dimensions.adjustedWidth;
9898
this.height = dimensions.adjustedHeight;
9999
this._autoSized = false;
@@ -175,7 +175,7 @@ class Framebuffer {
175175
resize(width, height) {
176176
this._autoSized = false;
177177
const dimensions =
178-
this.renderer._adjustDimensions(width, height);
178+
this.renderer._adjustDimensions(width, height, this.density);
179179
width = dimensions.adjustedWidth;
180180
height = dimensions.adjustedHeight;
181181
this.width = width;

src/webgl/p5.RendererGL.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -441,14 +441,14 @@ class RendererGL extends Renderer3D {
441441
return gl.getParameter(gl.MAX_TEXTURE_SIZE);
442442
}
443443

444-
_adjustDimensions(width, height) {
444+
_adjustDimensions(width, height, density = this._pixelDensity) {
445445
if (!this._maxTextureSize) {
446446
this._maxTextureSize = this._getMaxTextureSize();
447447
}
448448
let maxTextureSize = this._maxTextureSize;
449449

450450
let maxAllowedPixelDimensions = Math.floor(
451-
maxTextureSize / this._pixelDensity
451+
maxTextureSize / density
452452
);
453453
let adjustedWidth = Math.min(width, maxAllowedPixelDimensions);
454454
let adjustedHeight = Math.min(height, maxAllowedPixelDimensions);

0 commit comments

Comments
 (0)