Description
Most appropriate sub-area of p5.js?
- AccessibilityColorCore/Environment/RenderingDataDOMEventsImageIOMathTypographyUtilitiesWebGLBuild processUnit testingInternationalizationFriendly errorsOther (specify if possible)
p5.js version
dev-2.0
Web browser and version
Firefox
Operating system
MacOS
Steps to reproduce this
Currently, if you load a variable font (e.g. test/manual-test-examples/type/font/BricolageGrotesque-Variable.ttf
) in WebGL mode, word wrapping and measurement is currently broken because the parameters that Typr seems to read are different than the variables picked by default by the 2D canvas, which is what is used for measurement.
Typr now supports reading variable font data (photopea/Typr.js#56) so it seems like after updating Typr, we should be able to make these match!
One other complication: We currently associate one FontInfo
(containing font bezier cache data for WebGL) with one font:
Lines 687 to 690 in 05e35cb
However, we will need a new FontInfo
whenever any variable changes for the font, as that will change all the bezier data. So we likely will also need to have a cache by variable value in the font (possibly using a lot of memory if these change a lot? maybe needing an LRU cache to evict old ones?), or just invalidate the existing font info whenever variables change (possibly slow if this is animating every frame.)
Activity
dhowe commentedon Dec 24, 2024
I'm added an updated Typr version into our repo in #7449 so this is ready to work on
(note that Typr will hopefully be made into an npm package at some point, but it is now a manual process to upgrade)
fix: Fix variable fonts in WebGL mode
AritraDey-Dev commentedon Jan 6, 2025
@davepagurek
Thank you for bringing up this issue. I’ve addressed it and submitted a pull request. The problem with variable font measurement and word wrapping in WebGL mode has been fixed by:
Please verify my PR and let me know if you need any additional changes or tests!