Skip to content

Commit f453a05

Browse files
merge branch 'feature/v5.10.18'
2 parents f60f4de + 784c5ca commit f453a05

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+54
-61
lines changed

Sources/.nuget/NuGet.exe

31.5 KB
Binary file not shown.

Sources/ReCommendedExtension.Deployment/ReCommendedExtension.nuspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
<copyright>{{AssemblyCopyright}}</copyright>
3434
<tags>recommended extension resharper plugin addin prodot</tags>
3535
<dependencies>
36-
<dependency id="Wave" version="[233.0,233.1)" />
36+
<dependency id="Wave" version="[241.0,241.1)" />
3737
</dependencies>
3838
</metadata>
3939
<files>

Sources/ReCommendedExtension.Tests/Analyzers/AnnotationAnalyzerTestsForNUnitTestProjects.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@ protected override bool HighlightingPredicate(IHighlighting highlighting, IPsiSo
1717
=> highlighting is MissingSuppressionJustificationWarning;
1818

1919
[Test]
20-
[TestNetFramework47]
21-
[TestPackages("nunit")]
20+
[TestNetFramework46]
21+
[TestPackages("nunit/3.13.3")]
2222
public void TestSuppressMessage_TestProject() => DoNamedTest2();
2323

2424
[Test]
25-
[TestNet50("nunit")]
25+
[TestNet50("nunit/3.13.3")]
2626
public void TestSuppressMessage_TestProject_NET_5() => DoNamedTest2();
2727
}
2828
}

Sources/ReCommendedExtension.Tests/Analyzers/AnnotationAnalyzerTestsForXUnitTestProjects.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ protected override bool HighlightingPredicate(IHighlighting highlighting, IPsiSo
1717
=> highlighting is MissingSuppressionJustificationWarning;
1818

1919
[Test]
20-
[TestPackages("xunit.core")]
20+
[TestPackages("xunit.core/2.4.1")]
2121
public void TestSuppressMessage_TestProject() => DoNamedTest2();
2222

2323
[Test]
24-
[TestNet50("xunit.core")]
24+
[TestNet50("xunit.core/2.4.1")]
2525
public void TestSuppressMessage_TestProject_NET_5() => DoNamedTest2();
2626
}
2727
}

Sources/ReCommendedExtension.Tests/Analyzers/AwaitAnalyzerTestsRedundantCapturedContext.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
using JetBrains.Application.Settings;
2+
using JetBrains.ReSharper.Daemon.CSharp.Errors;
23
using JetBrains.ReSharper.Feature.Services.CSharp.PropertiesExtender;
34
using JetBrains.ReSharper.Feature.Services.Daemon;
45
using JetBrains.ReSharper.FeaturesTestFramework.Daemon;
@@ -15,7 +16,7 @@ public sealed class AwaitAnalyzerTestsRedundantCapturedContext : CSharpHighlight
1516
protected override string RelativeTestDataPath => @"Analyzers\Await";
1617

1718
protected override bool HighlightingPredicate(IHighlighting highlighting, IPsiSourceFile sourceFile, IContextBoundSettingsStore settingsStore)
18-
=> highlighting is RedundantCapturedContextSuggestion;
19+
=> highlighting is RedundantCapturedContextSuggestion || highlighting is RedundantConfigureAwaitWarning; // to figure out which cases are supported by R#
1920

2021
[TestNetFramework45]
2122
[Test]

Sources/ReCommendedExtension.Tests/ReCommendedExtension.Tests.csproj

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,8 @@
66
</PropertyGroup>
77

88
<ItemGroup>
9-
<PackageReference Include="JetBrains.Lifetimes" Version="2023.3.0" />
10-
<PackageReference Include="JetBrains.NuGet.Frameworks" Version="6.9.20240222.127" />
11-
<PackageReference Include="JetBrains.ReSharper.SDK.Tests" Version="2023.3.4">
9+
<PackageReference Include="JetBrains.Lifetimes" Version="2024.1.0" />
10+
<PackageReference Include="JetBrains.ReSharper.SDK.Tests" Version="2024.1.0">
1211
<PrivateAssets>all</PrivateAssets>
1312
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
1413
</PackageReference>

Sources/ReCommendedExtension.Tests/TestNetFramework47Attribute.cs

Lines changed: 0 additions & 16 deletions
This file was deleted.

Sources/ReCommendedExtension.sln.DotSettings

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -391,6 +391,11 @@
391391
<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/PredefinedNamingRules/=PrivateStaticFields/@EntryIndexedValue">&lt;Policy Inspect="False" Prefix="" Suffix="" Style="aaBb" /&gt;</s:String>
392392
<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/PredefinedNamingRules/=PrivateStaticReadonly/@EntryIndexedValue">&lt;Policy Inspect="False" Prefix="" Suffix="" Style="aaBb" /&gt;</s:String>
393393
<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/PredefinedNamingRules/=TypeParameters/@EntryIndexedValue">&lt;Policy Inspect="False" Prefix="T" Suffix="" Style="AaBb" /&gt;</s:String>
394+
<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/UserRules/=15b5b1f1_002D457c_002D4ca6_002Db278_002D5615aedc07d3/@EntryIndexedValue">&lt;Policy&gt;&lt;Descriptor Staticness="Static" AccessRightKinds="Private" Description="Static readonly fields (private)"&gt;&lt;ElementKinds&gt;&lt;Kind Name="READONLY_FIELD" /&gt;&lt;/ElementKinds&gt;&lt;/Descriptor&gt;&lt;Policy Inspect="False" Prefix="" Suffix="" Style="aaBb" /&gt;&lt;/Policy&gt;</s:String>
395+
<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/UserRules/=236f7aa5_002D7b06_002D43ca_002Dbf2a_002D9b31bfcff09a/@EntryIndexedValue">&lt;Policy&gt;&lt;Descriptor Staticness="Any" AccessRightKinds="Private" Description="Constant fields (private)"&gt;&lt;ElementKinds&gt;&lt;Kind Name="CONSTANT_FIELD" /&gt;&lt;/ElementKinds&gt;&lt;/Descriptor&gt;&lt;Policy Inspect="False" Prefix="" Suffix="" Style="aaBb" /&gt;&lt;/Policy&gt;</s:String>
396+
<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/UserRules/=2c62818f_002D621b_002D4425_002Dadc9_002D78611099bfcb/@EntryIndexedValue">&lt;Policy&gt;&lt;Descriptor Staticness="Any" AccessRightKinds="Any" Description="Type parameters"&gt;&lt;ElementKinds&gt;&lt;Kind Name="TYPE_PARAMETER" /&gt;&lt;/ElementKinds&gt;&lt;/Descriptor&gt;&lt;Policy Inspect="False" Prefix="T" Suffix="" Style="AaBb" /&gt;&lt;/Policy&gt;</s:String>
397+
<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/UserRules/=4a98fdf6_002D7d98_002D4f5a_002Dafeb_002Dea44ad98c70c/@EntryIndexedValue">&lt;Policy&gt;&lt;Descriptor Staticness="Instance" AccessRightKinds="Private" Description="Instance fields (private)"&gt;&lt;ElementKinds&gt;&lt;Kind Name="FIELD" /&gt;&lt;Kind Name="READONLY_FIELD" /&gt;&lt;/ElementKinds&gt;&lt;/Descriptor&gt;&lt;Policy Inspect="False" Prefix="" Suffix="" Style="aaBb" /&gt;&lt;/Policy&gt;</s:String>
398+
<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/UserRules/=f9fce829_002De6f4_002D4cb2_002D80f1_002D5497c44f51df/@EntryIndexedValue">&lt;Policy&gt;&lt;Descriptor Staticness="Static" AccessRightKinds="Private" Description="Static fields (private)"&gt;&lt;ElementKinds&gt;&lt;Kind Name="FIELD" /&gt;&lt;/ElementKinds&gt;&lt;/Descriptor&gt;&lt;Policy Inspect="False" Prefix="" Suffix="" Style="aaBb" /&gt;&lt;/Policy&gt;</s:String>
394399
<s:String x:Key="/Default/CodeStyle/Naming/XamlNaming/UserRules/=NAMESPACE_005FALIAS/@EntryIndexedValue">&lt;Policy Inspect="True" Prefix="" Suffix="" Style="aaBb" /&gt;</s:String>
395400
<s:String x:Key="/Default/CodeStyle/Naming/XamlNaming/UserRules/=XAML_005FFIELD/@EntryIndexedValue">&lt;Policy Inspect="True" Prefix="" Suffix="" Style="AaBb" /&gt;</s:String>
396401
<s:String x:Key="/Default/CodeStyle/Naming/XamlNaming/UserRules/=XAML_005FRESOURCE/@EntryIndexedValue">&lt;Policy Inspect="True" Prefix="" Suffix="" Style="AaBb" /&gt;</s:String>
@@ -444,6 +449,7 @@
444449
<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ESettingsUpgrade_002ECSharpPlaceAttributeOnSameLineMigration/@EntryIndexedValue">True</s:Boolean>
445450
<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ESettingsUpgrade_002EMigrateBlankLinesAroundFieldToBlankLinesAroundProperty/@EntryIndexedValue">True</s:Boolean>
446451
<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ESettingsUpgrade_002EMigrateThisQualifierSettings/@EntryIndexedValue">True</s:Boolean>
452+
<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ESettingsUpgrade_002EPredefinedNamingRulesToUserRulesUpgrade/@EntryIndexedValue">True</s:Boolean>
447453
<s:String x:Key="/Default/Environment/UserInterface/ShortcutSchemeName/@EntryValue">None</s:String>
448454
<s:Boolean x:Key="/Default/ReSpeller/DocCommentsUseMemberModifiers/@EntryValue">True</s:Boolean>
449455
<s:Boolean x:Key="/Default/ReSpeller/DontCheckInheritedMembers/@EntryValue">True</s:Boolean>

Sources/ReCommendedExtension/ContextActions/AnnotateWithInstantHandle.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
namespace ReCommendedExtension.ContextActions
99
{
1010
[ContextAction(
11-
Group = "C#",
11+
GroupType = typeof(CSharpContextActions),
1212
Name = "Annotate parameter with [InstantHandle] attribute" + ZoneMarker.Suffix,
1313
Description = "Annotates a parameter with the [InstantHandle] attribute.")]
1414
public sealed class AnnotateWithInstantHandle : AnnotateWithCodeAnnotation

Sources/ReCommendedExtension/ContextActions/AnnotateWithItemNotNull.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
namespace ReCommendedExtension.ContextActions
1111
{
1212
[ContextAction(
13-
Group = "C#",
13+
GroupType = typeof(CSharpContextActions),
1414
Name = "Annotate with [ItemNotNull] attribute" + ZoneMarker.Suffix,
1515
Description = "Annotates with the [ItemNotNull] attribute.")]
1616
public sealed class AnnotateWithItemNotNull : AnnotateWithCodeAnnotation

0 commit comments

Comments
 (0)