ci: fix Cygwin job (cygpath temp script, strip CRLF, use igncr)

Author: ritesh006

.github/workflows/cygwin-build.yml

@@ -3,25 +3,25 @@ name: Cygwin build
 on:
   pull_request:
   push:
-    branches: [ master ]
+    branches:
+      - master
 
 jobs:
   cygwin-build:
     runs-on: windows-latest
-
-    # Run ALL steps via Cygwin's bash (not Git Bash / CMD)
+    env:
+      CYGWIN: winsymlinks:nativestrict
     defaults:
       run:
-        shell: 'C:\tools\cygwin\bin\bash.EXE --login -eo pipefail -c "{0}"'
+        shell: C:\tools\cygwin\bin\bash.exe --login -eo pipefail -o igncr '{0}'
 
     steps:
-      - name: Checkout
+      - name: Checkout repository
         uses: actions/checkout@v4
         with:
-          # avoid CRLF issues inside Cygwin
           fetch-depth: 0
 
-      - name: Set up Cygwin with build deps
+      - name: Set up Cygwin with build dependencies
         uses: egor-tensin/setup-cygwin@v4
         with:
           packages: >-
@@ -33,24 +33,36 @@ jobs:
             autoconf-archive
             gcc-core
             gettext-devel
-            libstrophe-devel
+            git
             libncursesw-devel
             libglib2.0-devel
             libcurl-devel
             libreadline-devel
             libsqlite3-devel
 
-      - name: Sanity check Cygwin toolchain
+      - name: Build and install libstrophe from source
+        run: |
+          cd "$GITHUB_WORKSPACE"
+          mkdir -p deps && cd deps
+          git clone --depth 1 https://github.com/strophe/libstrophe.git
+          cd libstrophe
+          ./autogen.sh
+          ./configure --prefix=$PWD/install
+          make -j2 install
+        shell: C:\tools\cygwin\bin\bash.exe --login -eo pipefail -o igncr '{0}'
+
+      - name: Check repo state
         run: |
-          echo "PATH=$PATH"
-          type -a /usr/bin/uname || true
-          /usr/bin/uname -a
-          /usr/bin/gcc --version
-          /usr/bin/pkg-config --version
+          cd "$GITHUB_WORKSPACE"
+          pwd
+          ls -la
+          test -f configure.ac && echo "configure.ac present" || (echo "configure.ac missing"; exit 1)
 
       - name: Autotools bootstrap
         run: |
-          git config --global core.autocrlf false
+          cd "$GITHUB_WORKSPACE"
+          git config --global core.autocrlf false || true
+          [ -f ./bootstrap.sh ] && sed -i 's/\r$//' ./bootstrap.sh || true
           if [ -x ./bootstrap.sh ]; then
             ./bootstrap.sh
           else
@@ -59,12 +71,18 @@ jobs:
 
       - name: Configure
         env:
-          CYGWIN: winsymlinks:nativestrict
-        run: ./configure
+          PKG_CONFIG_PATH: ${{ github.workspace }}/deps/libstrophe/install/lib/pkgconfig:$PKG_CONFIG_PATH
+        run: |
+          cd "$GITHUB_WORKSPACE"
+          ./configure
 
       - name: Build
-        run: make -j2
+        run: |
+          cd "$GITHUB_WORKSPACE"
+          make -j2
 
-      # keep tests for later; first make the build go green
+      # Uncomment when tests are reliable on Cygwin
       # - name: Test
-      #   run: make check -j2
+      #   run: |
+      #     cd "$GITHUB_WORKSPACE"
+      #     make check -j2