Skip to content

bug: numsub command should require NonEmptyList of redisChannel #1090

@yisraelU

Description

@yisraelU

While the Redis documentation says

Note that it is valid to call this command without channels. In this case it will just return an empty list.

Lettuce does not implement this pattern and calling numsub will result in an Exception being thrown
see https://github.com/redis/lettuce/blob/e80bb0b39cff4d73655821108a640e79dd90e3a7/src/main/java/io/lettuce/core/pubsub/PubSubCommandBuilder.java#L69
the underlying command for numSub requires at least one channel to be passed in .
The current implementation here is invalid and will result in Lettuce throwing an exception at runtime .
There are currently no tests for the numSub command

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions