Alphabetize quality column

Author: hasty

disco/attributes.go

@@ -40,6 +40,11 @@ func (b *Baller) organizeAttributesSection(cxt *discoContext) (err error) {
 			return err
 		}
 
+		err = b.fixQualityCells(cxt, attributes)
+		if err != nil {
+			return err
+		}
+
 		err = b.fixConstraintCells(cxt, attributes.section, attributesTable)
 		if err != nil {
 			return err

disco/commands.go

@@ -35,6 +35,11 @@ func (b *Baller) organizeCommandsSection(cxt *discoContext) (err error) {
 			return fmt.Errorf("error fixing access cells in commands table in %s: %w", cxt.doc.Path, err)
 		}
 
+		err = b.fixQualityCells(cxt, commands)
+		if err != nil {
+			return err
+		}
+
 		err = b.fixConformanceCells(cxt, commands, commands.table.Rows, commands.table.ColumnMap)
 		if err != nil {
 			return fmt.Errorf("error fixing conformance cells in commands table in %s: %w", cxt.doc.Path, err)

disco/event.go

@@ -34,6 +34,11 @@ func (b *Baller) organizeEventsSection(cxt *discoContext) (err error) {
 			return fmt.Errorf("error fixing access cells in section %s in %s: %w", cxt.doc.SectionName(events.section), cxt.doc.Path, err)
 		}
 
+		err = b.fixQualityCells(cxt, events)
+		if err != nil {
+			return err
+		}
+
 		err = b.fixConformanceCells(cxt, events, eventsTable.Rows, eventsTable.ColumnMap)
 		if err != nil {
 			return fmt.Errorf("error fixing conformance cells for event table in section %s in %s: %w", cxt.doc.SectionName(events.section), cxt.doc.Path, err)

disco/option.go

@@ -8,6 +8,7 @@ type DiscoOptions struct {
 	ReorderColumns                bool `default:"true" aliases:"reorderColumns" help:"rearrange table columns into disco-ball order" group:"Discoballing:"`
 	RenameTableHeaders            bool `default:"true" aliases:"renameTableHeaders" help:"rename table headers to disco-ball standard names" group:"Discoballing:"`
 	FormatAccess                  bool `default:"true" aliases:"formatAccess" help:"reformat access columns in disco-ball order" group:"Discoballing:"`
+	FormatQuality                 bool `default:"true" help:"reformat quality columns in disco-ball order" group:"Discoballing:"`
 	PromoteDataTypes              bool `default:"true" aliases:"promoteDataTypes" help:"promote inline data types to Data Types section" group:"Discoballing:"`
 	ReorderSections               bool `default:"true" aliases:"reorderSections" help:"reorder sections in disco-ball order" group:"Discoballing:"`
 	NormalizeTableOptions         bool `default:"true" aliases:"normalizeTableOptions" help:"remove existing table options and replace with standard disco-ball options" group:"Discoballing:"`
@@ -29,6 +30,7 @@ var DefaultOptions = DiscoOptions{
 	ReorderColumns:                true,
 	RenameTableHeaders:            true,
 	FormatAccess:                  true,
+	FormatQuality:                 true,
 	PromoteDataTypes:              true,
 	ReorderSections:               true,
 	NormalizeTableOptions:         true,

disco/quality.go

@@ -0,0 +1,44 @@
+package disco
+
+import (
+	"strings"
+
+	"github.com/project-chip/alchemy/errata"
+	"github.com/project-chip/alchemy/matter"
+	"github.com/project-chip/alchemy/matter/spec"
+)
+
+func (b *Baller) fixQualityCells(cxt *discoContext, subSection *subSection) (err error) {
+	if !b.options.FormatQuality {
+		return nil
+	}
+	if cxt.errata.IgnoreSection(cxt.doc.SectionName(subSection.section), errata.DiscoPurposeTableQuality) {
+		return nil
+	}
+	table := subSection.table
+	if len(table.Rows) < 2 {
+		return
+	}
+	qualityIndex, ok := table.ColumnMap[matter.TableColumnQuality]
+	if !ok {
+		return
+	}
+
+	for _, row := range table.Rows[1:] {
+		qualityCell := row.Cell(qualityIndex)
+		vc, e := spec.RenderTableCell(qualityCell)
+		if e != nil {
+			continue
+		}
+		vc = strings.TrimSpace(vc)
+		if len(vc) == 0 {
+			continue
+		}
+		quality := matter.ParseQuality(vc)
+		replacementQuality := quality.String()
+		if vc != replacementQuality {
+			setCellString(qualityCell, replacementQuality)
+		}
+	}
+	return
+}

disco/struct.go

@@ -48,6 +48,11 @@ func (b *Baller) organizeStructSection(cxt *discoContext, ss *subSection) (err e
 		return fmt.Errorf("error fixing access cells in struct table in %s: %w", cxt.doc.Path, err)
 	}
 
+	err = b.fixQualityCells(cxt, ss)
+	if err != nil {
+		return err
+	}
+
 	err = b.fixConstraintCells(cxt, ss.section, fieldsTable)
 	if err != nil {
 		return err

errata/disco.go

@@ -45,14 +45,16 @@ const (
 	DiscoPurposeDataTypeCommandFixDirection              = 1 << (iota - 1)
 	DiscoPurposeDataTypePromoteInline                    = 1 << (iota - 1)
 	DiscoPurposeNormalizeAnchor                          = 1 << (iota - 1)
+	DiscoPurposeTableQuality                             = 1 << (iota - 1)
 
-	DiscoPurposeAll DiscoPurpose = DiscoPurposeTableAccess | DiscoPurposeTableConformance | DiscoPurposeTableConstraint | DiscoPurposeTableLinkIndexes | DiscoPurposeTableRenameHeaders | DiscoPurposeTableAddMissingColumns | DiscoPurposeTableReorderColumns | DiscoPurposeDataTypeAppendSuffix | DiscoPurposeDataTypeRename
+	DiscoPurposeAll DiscoPurpose = DiscoPurposeTableAccess | DiscoPurposeTableConformance | DiscoPurposeTableConstraint | DiscoPurposeTableLinkIndexes | DiscoPurposeTableQuality | DiscoPurposeTableRenameHeaders | DiscoPurposeTableAddMissingColumns | DiscoPurposeTableReorderColumns | DiscoPurposeDataTypeAppendSuffix | DiscoPurposeDataTypeRename
 )
 
 var discoPurposes = map[string]DiscoPurpose{
 	"table-access":                    DiscoPurposeTableAccess,
 	"table-conformance":               DiscoPurposeTableConformance,
 	"table-constraint":                DiscoPurposeTableConstraint,
+	"table-quality":                   DiscoPurposeTableQuality,
 	"table-link-indexes":              DiscoPurposeTableLinkIndexes,
 	"table-rename-headers":            DiscoPurposeTableRenameHeaders,
 	"table-add-missing-columns":       DiscoPurposeTableRenameHeaders,

matter/quality.go

@@ -1,6 +1,7 @@
 package matter
 
 import (
+	"slices"
 	"strings"
 
 	"github.com/project-chip/alchemy/matter/types"
@@ -79,13 +80,21 @@ func (q Quality) Any(o Quality) bool {
 }
 
 func (q Quality) String() string {
-	var s strings.Builder
+	var qualities []rune
 	for tq, i := range qualityIdentifiers {
 		if (q & tq) == tq {
-			s.WriteRune(i)
+			qualities = append(qualities, i)
 		}
 	}
-	return s.String()
+	slices.Sort(qualities)
+	var sb strings.Builder
+	for _, r := range qualities {
+		if sb.Len() > 0 {
+			sb.WriteRune(' ')
+		}
+		sb.WriteRune(r)
+	}
+	return sb.String()
 }
 
 func (q *Quality) Inherit(oq Quality) {