Fix findings

Author: AryaHassanli

cmd/action/zapdiff.go

@@ -32,7 +32,7 @@ type ZAPDiff struct {
 
 func (z *ZAPDiff) Run(cc *cli.Context) (err error) {
 	slog.Info("Running ZAP generation", "attributes", z.GenAttributes)
-	zapCmd := &cli.ZAP{}
+	zapCmd := &cli.ZAPXML{}
 	zapCmd.Root = z.SpecRoot
 	zapCmd.SdkRoot = z.GeneratedSDKRoot
 	zapCmd.Attribute = []string{z.GenAttributes}

zap/regen/case.go

@@ -6,7 +6,6 @@ import (
 	"unicode"
 
 	"github.com/mailgun/raymond/v2"
-	"github.com/project-chip/alchemy/internal/text"
 )
 
 func asUpperCamelCaseHelper(value string) raymond.SafeString {
@@ -18,7 +17,7 @@ func asUpperCamelCaseIgnoreAcronymsHelper(value string) raymond.SafeString {
 }
 
 func asLowerCamelCaseHelper(value string) raymond.SafeString {
-	if len(value) > 1 && text.IsUpperCase(value) {
+	if len(value) > 1 && isUpperCase(value) {
 		return raymond.SafeString(strings.ToLower(value))
 	}
 	return raymond.SafeString(caseify(value, true, true))

zap/regen/helper.go

@@ -142,10 +142,7 @@ func maxValue(field matter.Field, fs matter.FieldSet) (max types.DataTypeExtreme
 		return
 	}
 
-	var maxDueToNullable bool
-	if hasNumericMax {
-		maxDueToNullable = types.Max(sdk.ToUnderlyingType(sdk.FindBaseType(field.Type)), types.NullabilityNullable).ValueEquals(max)
-	}
+	maxDueToNullable := types.Max(sdk.ToUnderlyingType(sdk.FindBaseType(field.Type)), types.NullabilityNullable).ValueEquals(max)
 	if maxDueToNullable {
 		return
 	}
@@ -208,7 +205,7 @@ func accessStringHelper(a matter.Access) raymond.SafeString {
 		list.WriteString("read: ")
 		list.WriteString(strings.ToLower(a.Read.String()))
 	}
-	if a.Write != matter.PrivilegeUnknown && a.Write != matter.PrivilegeView {
+	if a.Write != matter.PrivilegeUnknown && a.Write != matter.PrivilegeOperate {
 		if list.Len() > 0 {
 			list.WriteString(", ")
 		}
@@ -253,7 +250,7 @@ func descriptionCommentHelper(description string) raymond.SafeString {
 	var comment strings.Builder
 	var line strings.Builder
 	line.WriteString("/**")
-	words := strings.Split(description, " ")
+	words := strings.Fields(description)
 	for _, word := range words {
 		if line.Len() > 100 {
 			comment.WriteString(line.String())

zap/regen/render.go

@@ -88,7 +88,7 @@ func (p IdlRenderer) Process(cxt context.Context, input *pipeline.Data[*zap.File
 	clusters := make(map[*matter.Cluster]*ClusterInfo)
 
 	for _, endpoint := range input.Content.Endpoints {
-		if endpoint.EndpointTypeIndex > len(input.Content.EndpointTypes)-1 {
+		if endpoint.EndpointTypeIndex < 0 || endpoint.EndpointTypeIndex >= len(input.Content.EndpointTypes) {
 			continue
 		}
 		endpointType := input.Content.EndpointTypes[endpoint.EndpointTypeIndex]
@@ -120,6 +120,9 @@ func (p IdlRenderer) Process(cxt context.Context, input *pipeline.Data[*zap.File
 	clusterList := make([]*ClusterInfo, 0, len(clusters))
 	clusterEntities := make(map[*matter.Cluster]map[types.Entity]struct{})
 	globalEntities := make(map[types.Entity]bool)
+	for entity := range p.spec.GlobalObjects {
+		globalEntities[entity] = false
+	}
 	for cluster, ci := range clusters {
 		clusterList = append(clusterList, ci)
 		clusterEntities[cluster] = make(map[types.Entity]struct{})
@@ -196,7 +199,7 @@ func (p IdlRenderer) Process(cxt context.Context, input *pipeline.Data[*zap.File
 		en.Name = fieldName + "Tag"
 		en.Type = types.NewDataType(types.BaseDataTypeEnum8, types.DataTypeRankScalar)
 		for _, tag := range ns.SemanticTags {
-			nst := matter.NewEnumValue(tag.Source(), ns)
+			nst := matter.NewEnumValue(tag.Source(), en)
 			nst.Name = tag.Name
 			nst.Value = tag.ID
 			en.Values = append(en.Values, nst)

zap/regen/targeter.go

@@ -16,6 +16,9 @@ func getZapPaths(sdkRoot string) (zapPaths []string, err error) {
 	zapPaths = append(zapPaths, filepath.Join(sdkRoot, "src/controller/data_model/controller-clusters.zap"))
 	srcRoot := filepath.Join(sdkRoot, "/examples/")
 	err = filepath.WalkDir(srcRoot, func(path string, d fs.DirEntry, err error) error {
+		if err != nil {
+			return err
+		}
 		if filepath.Ext(path) == ".zap" {
 			zapPaths = append(zapPaths, path)
 		}