Skip to content

Commit 2b22353

Browse files
committed
fix: android: do not initialize tracing if it is disabled
1 parent d6b2cee commit 2b22353

File tree

2 files changed

+25
-11
lines changed

2 files changed

+25
-11
lines changed

src/platform/android/AndroidChipPlatform-JNI.cpp

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,18 @@
3737

3838
#include <android/log.h>
3939

40+
#include <matter/tracing/build_config.h>
41+
4042
#include "AndroidChipPlatform-JNI.h"
4143
#include "BLEManagerImpl.h"
4244
#include "BleConnectCallback-JNI.h"
4345
#include "CommissionableDataProviderImpl.h"
4446
#include "DiagnosticDataProviderImpl.h"
4547
#include "DnssdImpl.h"
48+
49+
#if MATTER_TRACING_ENABLED
4650
#include "tracing.h"
51+
#endif // MATTER_TRACING_ENABLED
4752

4853
using namespace chip;
4954

@@ -97,7 +102,9 @@ CHIP_ERROR AndroidChipPlatformJNI_OnLoad(JavaVM * jvm, void * reserved)
97102
err = BleConnectCallbackJNI_OnLoad(jvm, reserved);
98103
SuccessOrExit(err);
99104

105+
#if MATTER_TRACING_ENABLED
100106
chip::Android::InitializeTracing();
107+
#endif // MATTER_TRACING_ENABLED
101108
exit:
102109
if (err != CHIP_NO_ERROR)
103110
{
@@ -110,7 +117,9 @@ CHIP_ERROR AndroidChipPlatformJNI_OnLoad(JavaVM * jvm, void * reserved)
110117

111118
void AndroidChipPlatformJNI_OnUnload(JavaVM * jvm, void * reserved)
112119
{
120+
#if MATTER_TRACING_ENABLED
113121
chip::Android::ShutdownTracing();
122+
#endif // MATTER_TRACING_ENABLED
114123

115124
ChipLogProgress(DeviceLayer, "AndroidChipPlatform JNI_OnUnload() called");
116125
BleConnectCallbackJNI_OnUnload(jvm, reserved);

src/platform/android/BUILD.gn

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -19,21 +19,26 @@ import("${chip_root}/src/platform/device.gni")
1919

2020
import("${build_root}/config/android_abi.gni")
2121
import("${chip_root}/build/chip/java/rules.gni")
22+
import("${chip_root}/src/tracing/tracing_args.gni")
2223

2324
assert(chip_device_platform == "android")
2425

2526
source_set("tracing") {
26-
sources = [
27-
"tracing.cpp",
28-
"tracing.h",
29-
]
30-
31-
deps = [
32-
"${chip_root}/src/lib/support",
33-
"${chip_root}/src/tracing",
34-
"${chip_root}/src/tracing/perfetto:event_storage",
35-
"${chip_root}/src/tracing/perfetto:simple_initialization",
36-
]
27+
deps = [ "${chip_root}/src/tracing:tracing_buildconfig" ]
28+
29+
if (matter_enable_tracing_support) {
30+
sources = [
31+
"tracing.cpp",
32+
"tracing.h",
33+
]
34+
35+
deps += [
36+
"${chip_root}/src/lib/support",
37+
"${chip_root}/src/tracing",
38+
"${chip_root}/src/tracing/perfetto:event_storage",
39+
"${chip_root}/src/tracing/perfetto:simple_initialization",
40+
]
41+
}
3742
}
3843

3944
static_library("logging") {

0 commit comments

Comments
 (0)