Skip to content

Commit 6082828

Browse files
committed
Moved server to use global structs and enum
1 parent 5906ee3 commit 6082828

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

src/app/clusters/soil-measurement-server/soil-measurement-server.cpp

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,10 @@ using namespace chip::app;
3737
using namespace chip::app::Clusters;
3838
using namespace chip::app::Clusters::SoilMeasurement;
3939
using namespace chip::app::Clusters::SoilMeasurement::Attributes;
40-
using namespace chip::app::Clusters::SoilMeasurement::Structs;
4140

4241
MeasurementData gMeasurements[MATTER_DM_SOIL_MEASUREMENT_CLUSTER_SERVER_ENDPOINT_COUNT + CHIP_DEVICE_CONFIG_DYNAMIC_ENDPOINT_COUNT];
4342

44-
MeasurementAccuracyRangeStruct::Type soilMoistureMeasurementLimitsAccuracyRange[] = {
43+
Globals::Structs::MeasurementAccuracyRangeStruct::Type soilMoistureMeasurementLimitsAccuracyRange[] = {
4544
{ .rangeMin = 0, .rangeMax = 100, .percentMax = MakeOptional(static_cast<chip::Percent100ths>(10)) }
4645
};
4746

@@ -52,12 +51,14 @@ CHIP_ERROR SoilMeasurementAttrAccess::Init()
5251
// Initialize the soil moisture measurement limits to default values
5352
for (auto & measurement : gMeasurements)
5453
{
55-
measurement.soilMoistureMeasurementLimits = { .measurementType = MeasurementTypeEnum::kSoilMoisture,
56-
.measured = true,
57-
.minMeasuredValue = 0,
58-
.maxMeasuredValue = 100,
59-
.accuracyRanges = DataModel::List<const MeasurementAccuracyRangeStruct::Type>(
60-
soilMoistureMeasurementLimitsAccuracyRange) };
54+
measurement.soilMoistureMeasurementLimits = {
55+
.measurementType = Globals::MeasurementTypeEnum::kSoilMoisture,
56+
.measured = true,
57+
.minMeasuredValue = 0,
58+
.maxMeasuredValue = 100,
59+
.accuracyRanges = DataModel::List<const Globals::Structs::MeasurementAccuracyRangeStruct::Type>(
60+
soilMoistureMeasurementLimitsAccuracyRange)
61+
};
6162
}
6263

6364
return CHIP_NO_ERROR;
@@ -107,7 +108,8 @@ MeasurementData * SoilMeasurementDataForEndpoint(EndpointId endpointId)
107108
// This function is intended for the application to set the soil measurement accuracy limits to the proper values during init.
108109
// Given the limits are fixed, it is not intended to be changes at runtime, hence why this function does not report the change.
109110
// The application should call this function only once during init.
110-
CHIP_ERROR SetSoilMeasurementAccuracy(EndpointId endpointId, const MeasurementAccuracyStruct::Type & measurementLimits)
111+
CHIP_ERROR SetSoilMeasurementAccuracy(EndpointId endpointId,
112+
const Globals::Structs::MeasurementAccuracyStruct::Type & measurementLimits)
111113
{
112114
MeasurementData * data = SoilMeasurementDataForEndpoint(endpointId);
113115
VerifyOrReturnError(data != nullptr, CHIP_ERROR_INVALID_ARGUMENT);

src/app/clusters/soil-measurement-server/soil-measurement-server.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ namespace SoilMeasurement {
3232

3333
struct MeasurementData
3434
{
35-
Structs::MeasurementAccuracyStruct::Type soilMoistureMeasurementLimits;
35+
Globals::Structs::MeasurementAccuracyStruct::Type soilMoistureMeasurementLimits;
3636
};
3737

3838
class SoilMeasurementAttrAccess : public AttributeAccessInterface
@@ -50,7 +50,7 @@ class SoilMeasurementAttrAccess : public AttributeAccessInterface
5050
private:
5151
};
5252

53-
CHIP_ERROR SetSoilMeasurementAccuracy(EndpointId endpointId, const Structs::MeasurementAccuracyStruct::Type & accuracy);
53+
CHIP_ERROR SetSoilMeasurementAccuracy(EndpointId endpointId, const Globals::Structs::MeasurementAccuracyStruct::Type & accuracy);
5454

5555
MeasurementData * SoilMeasurementDataForEndpoint(EndpointId endpointId);
5656

0 commit comments

Comments
 (0)