Skip to content

Commit 9189b28

Browse files
Re-enable Darwin tests that have been fixed. (#38972)
This reverts commit 47b3a6a. The subscription pool tests were fixed in #38854. testMTRDeviceDealloc was fixed in #38809. Both happened before the PR to disable them got through review and landed.
1 parent fae20e2 commit 9189b28

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

src/darwin/Framework/CHIPTests/MTRPerControllerStorageTests.m

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2963,8 +2963,6 @@ - (void)doTestSubscriptionPoolWithSize:(NSInteger)subscriptionPoolSize deviceOnb
29632963

29642964
- (void)testSubscriptionPool
29652965
{
2966-
XCTSkip("Skipping due to flakyness/failing. https://github.com/project-chip/connectedhomeip/issues/38825");
2967-
29682966
// QRCodes generated for discriminators 1111~1115 and passcodes 1001~1005
29692967
NSDictionary<NSNumber *, NSString *> * deviceOnboardingPayloads = @{
29702968
@(101) : @"MT:00000UZ427U0D900000",
@@ -2989,8 +2987,6 @@ - (void)testSubscriptionPool
29892987

29902988
- (void)testSubscriptionPoolManyDevices
29912989
{
2992-
XCTSkip("Skipping due to flakyness/failing. https://github.com/project-chip/connectedhomeip/issues/38825");
2993-
29942990
// QRCodes generated for discriminators 1111~1150 and passcodes 1001~1050
29952991
NSDictionary<NSNumber *, NSString *> * deviceOnboardingPayloads = @{
29962992
@(101) : @"MT:00000I9K17U0D900000",
@@ -3672,9 +3668,6 @@ - (void)testMTRDeviceResetSubscription
36723668

36733669
- (void)testMTRDeviceDealloc
36743670
{
3675-
// disabled: see https://github.com/project-chip/connectedhomeip/issues/38715
3676-
XCTSkip("Skipping due to flakyness/failing. (https://github.com/project-chip/connectedhomeip/issues/38715)");
3677-
36783671
__auto_type * storageDelegate = [[MTRTestPerControllerStorageWithBulkReadWrite alloc] initWithControllerID:[NSUUID UUID]];
36793672

36803673
__auto_type * factory = [MTRDeviceControllerFactory sharedInstance];

0 commit comments

Comments
 (0)