Skip to content

Commit 97834a3

Browse files
committed
Move the configuration to the existing declare_args() region
Not enabling Wi-Fi-PAF in the test example Signed-off-by: Lo,Chin-Ran <[email protected]>
1 parent cd0e4d0 commit 97834a3

File tree

6 files changed

+11
-8
lines changed

6 files changed

+11
-8
lines changed

.github/workflows/build.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ jobs:
193193
- name: Setup and Build Simulated Device
194194
run: |
195195
BUILD_TYPE=simulated
196-
GN_ARGS='chip_tests_zap_config="app1" chip_project_config_include_dirs=["../../examples/placeholder/linux/apps/app1/include", "../../config/standalone"] chip_config_network_layer_ble=false'
196+
GN_ARGS='chip_tests_zap_config="app1" chip_project_config_include_dirs=["../../examples/placeholder/linux/apps/app1/include", "../../config/standalone"] chip_config_network_layer_ble=false chip_device_config_enable_wifipaf=false'
197197
CHIP_ROOT_PATH=examples/placeholder/linux
198198
CHIP_ROOT_PATH="$CHIP_ROOT_PATH" BUILD_TYPE="$BUILD_TYPE" scripts/build/gn_gen.sh --args="$GN_ARGS"
199199
scripts/run_in_build_env.sh "ninja -C ./out/$BUILD_TYPE"

.github/workflows/tests.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838

3939
strategy:
4040
matrix:
41-
build_variant: [no-ble-no-shell-tsan-clang]
41+
build_variant: [no-ble-no-wifipaf-no-shell-tsan-clang]
4242
chip_tool: [""]
4343
env:
4444
BUILD_VARIANT: ${{matrix.build_variant}}

scripts/build/build/targets.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,11 @@ def BuildHostTarget():
122122
TargetPart('shell', app=HostApp.SHELL),
123123
TargetPart('ota-provider', app=HostApp.OTA_PROVIDER, enable_ble=False),
124124
TargetPart('ota-requestor', app=HostApp.OTA_REQUESTOR,
125-
enable_ble=False),
125+
enable_ble=False, enable_wifipaf=False),
126126
TargetPart('simulated-app1', app=HostApp.SIMULATED_APP1,
127-
enable_ble=False),
127+
enable_ble=False, enable_wifipaf=False),
128128
TargetPart('simulated-app2', app=HostApp.SIMULATED_APP2,
129-
enable_ble=False),
129+
enable_ble=False, enable_wifipaf=False),
130130
TargetPart('python-bindings', app=HostApp.PYTHON_BINDINGS),
131131
TargetPart('tv-app', app=HostApp.TV_APP),
132132
TargetPart('tv-casting-app', app=HostApp.TV_CASTING),
@@ -173,6 +173,7 @@ def BuildHostTarget():
173173
'no-interactive', interactive_mode=False).OnlyIfRe('-chip-tool')
174174
target.AppendModifier("ipv6only", enable_ipv4=False)
175175
target.AppendModifier("no-ble", enable_ble=False)
176+
target.AppendModifier("no-wifipaf", enable_wifipaf=False)
176177
target.AppendModifier("no-wifi", enable_wifi=False)
177178
target.AppendModifier("no-thread", enable_thread=False)
178179
target.AppendModifier('no-shell', disable_shell=True)

scripts/build/builders/host.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ def PlatformName(self):
350350
class HostBuilder(GnBuilder):
351351

352352
def __init__(self, root, runner, app: HostApp, board=HostBoard.NATIVE,
353-
enable_ipv4=True, enable_ble=True, enable_wifi=True,
353+
enable_ipv4=True, enable_ble=True, enable_wifi=True, enable_wifipaf=True,
354354
enable_thread=True, use_tsan=False, use_asan=False, use_ubsan=False,
355355
separate_event_loop=True, fuzzing_type: HostFuzzingType = HostFuzzingType.NONE, use_clang=False,
356356
interactive_mode=True, extra_tests=False, use_nl_fault_injection=False, use_platform_mdns=False, enable_rpcs=False,
@@ -383,6 +383,9 @@ def __init__(self, root, runner, app: HostApp, board=HostBoard.NATIVE,
383383
self.extra_gn_options.append('chip_config_network_layer_ble=false')
384384
self.extra_gn_options.append('chip_enable_ble=false')
385385

386+
if not enable_wifipaf:
387+
self.extra_gn_options.append('chip_device_config_enable_wifipaf=false')
388+
386389
if not enable_wifi:
387390
self.extra_gn_options.append('chip_enable_wifi=false')
388391

scripts/examples/gn_build_test_example.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ function runGN() {
4444
GN_ARGS="chip_tests_zap_config=\"$APP_DIR\""
4545
GN_ARGS+="chip_project_config_include_dirs=[\"$INPUT_DIR/apps/$APP_DIR/include\", \"$CHIP_ROOT/config/standalone\"]"
4646
GN_ARGS+="chip_config_network_layer_ble=false"
47+
GN_ARGS+="chip_device_config_enable_wifipaf=false"
4748

4849
gn gen --check --fail-on-unused-args --root=examples/placeholder/linux "$CHIP_ROOT/out/$APP_DIR" --args="$GN_ARGS"
4950
}

src/platform/device.gni

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,9 +123,7 @@ declare_args() {
123123
declare_args() {
124124
# Enable Joint Fabric features
125125
chip_device_config_enable_joint_fabric = false
126-
}
127126

128-
declare_args() {
129127
# Include wifi-paf to commission the device or not
130128
# This is a feature of Wi-Fi spec that it can be enabled if wifi is enabled
131129
# and the supplicant can support.

0 commit comments

Comments
 (0)