refactor(thermostat): centralize ActivePresetHandle subscription reporting

Co-authored-by: Copilot <copilot@github.com>

Author: lboue

examples/thermostat/thermostat-common/src/thermostat-delegate-impl.cpp

@@ -168,6 +168,11 @@ CHIP_ERROR ThermostatDelegate::SetActivePresetHandle(const DataModel::Nullable<B
         mActivePresetHandleDataSize = 0;
         ChipLogDetail(NotSpecified, "Clear ActivePresetHandle");
     }
+
+    // Centralize ActivePresetHandle reporting here so all update paths
+    // calling SetActivePresetHandle trigger a consistent subscription report.
+    MatterReportingAttributeChangeCallback(mEndpointId, Thermostat::Id, Attributes::ActivePresetHandle::Id);
+
     return CHIP_NO_ERROR;
 }
 
@@ -449,7 +454,6 @@ CHIP_ERROR ThermostatDelegate::ReEvaluateCurrentSuggestion()
         // ActivePresetHandle. Otherwise set the ActivePresetHandle to the preset handle in the suggestion and set
         // ThermostatSuggestionNotFollowingReason to null.
         TEMPORARY_RETURN_IGNORED SetActivePresetHandle(currentThermostatSuggestion.GetPresetHandle());
-        MatterReportingAttributeChangeCallback(mEndpointId, Thermostat::Id, Attributes::ActivePresetHandle::Id);
         TEMPORARY_RETURN_IGNORED SetThermostatSuggestionNotFollowingReason(DataModel::NullNullable);
 
         // Start a timer from the timestamp in currentMatterEpochTimestamp to the timestamp in the expiration time.

src/app/clusters/thermostat-server/ThermostatClusterPresets.cpp

@@ -309,6 +309,8 @@ Status ThermostatAttrAccess::SetActivePreset(EndpointId endpoint, DataModel::Nul
         return Status::InvalidCommand;
     }
 
+    // Delegate centralizes ActivePresetHandle subscription reporting to ensure
+    // all update paths (command and suggestion-driven) emit reports consistently.
     CHIP_ERROR err = delegate->SetActivePresetHandle(presetHandle);
 
     if (err != CHIP_NO_ERROR)
@@ -317,10 +319,6 @@ Status ThermostatAttrAccess::SetActivePreset(EndpointId endpoint, DataModel::Nul
         return StatusIB(err).mStatus;
     }
 
-    // Notify subscribers that ActivePresetHandle has changed so that they
-    // receive a subscription report with the new value.
-    MatterReportingAttributeChangeCallback(endpoint, Thermostat::Id, ActivePresetHandle::Id);
-
     return Status::Success;
 }