Skip to content

Commit ed45c69

Browse files
committed
Fix the commissioner_tests executable name
1 parent fc68c01 commit ed45c69

2 files changed

Lines changed: 16 additions & 16 deletions

File tree

rs-matter/src/onboard.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
//! (ICAC private key, `fab_idx`, NOC-serial / next-NodeID counters,
4747
//! the fabric itself) is theirs to write and read back.
4848
//!
49-
//! See `tests/commissioning.rs` and `examples/src/bin/commissioner_test.rs`
49+
//! See `tests/commissioning.rs` and `examples/src/bin/commissioner_tests.rs`
5050
//! for a fully-worked example wiring of all of the above against a
5151
//! single in-process fabric.
5252
//!

xtask/src/itest.rs

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -544,7 +544,7 @@ impl TestSuite {
544544
Self::System | Self::SystemPython | Self::SystemYaml => "chip_tool_tests",
545545
Self::Camera => "camera_tests",
546546
Self::Light => "dimmable_light",
547-
Self::Commissioner => "commissioner_test",
547+
Self::Commissioner => "commissioner_tests",
548548
}
549549
}
550550

@@ -798,8 +798,8 @@ impl ITests {
798798
/// `[::1]:<COMMISSIONER_DEVICE_PORT>` with a known passcode +
799799
/// discriminator + an ephemeral KVS file (so commissioning state
800800
/// doesn't carry across runs), then runs the rs-matter
801-
/// `commissioner_test` example against it. Asserts the example
802-
/// exits 0 and prints the expected `commissioner_test: ok …` line.
801+
/// `commissioner_tests` example against it. Asserts the example
802+
/// exits 0 and prints the expected `commissioner_tests: ok …` line.
803803
/// Kills the spawned app on success or failure.
804804
fn run_commissioner_suite(
805805
&self,
@@ -844,7 +844,7 @@ impl ITests {
844844
let _ = std::fs::remove_file(&kvs_path);
845845

846846
// 3. Spawn the DUT. Bind to IPv6 loopback only (matches what
847-
// `commissioner_test` peers against by default). Drain its
847+
// `commissioner_tests` peers against by default). Drain its
848848
// stdout/stderr to a background thread so the pipe buffer
849849
// doesn't fill up and stall the subprocess.
850850
info!(
@@ -911,12 +911,12 @@ impl ITests {
911911
.stdout(Stdio::piped())
912912
.stderr(Stdio::piped())
913913
.spawn()
914-
.map_err(|e| anyhow::anyhow!("failed to spawn commissioner_test: {e}"))?;
914+
.map_err(|e| anyhow::anyhow!("failed to spawn commissioner_tests: {e}"))?;
915915

916916
let controller_stdout = controller.stdout.take().expect("piped");
917917
let controller_stderr = controller.stderr.take().expect("piped");
918918

919-
// Capture controller stdout to extract the `commissioner_test:
919+
// Capture controller stdout to extract the `commissioner_tests:
920920
// ok ...` line; also stream stderr to the operator.
921921
let (success_tx, success_rx) = mpsc::channel::<String>();
922922
let success_tx_clone = success_tx.clone();
@@ -925,9 +925,9 @@ impl ITests {
925925
let reader = BufReader::new(controller_stdout);
926926
for line in reader.lines().map_while(Result::ok) {
927927
if print_ctrl_output {
928-
println!("[commissioner_test stdout] {line}");
928+
println!("[commissioner_tests stdout] {line}");
929929
}
930-
if line.starts_with("commissioner_test: ok ") {
930+
if line.starts_with("commissioner_tests: ok ") {
931931
let _ = success_tx_clone.send(line);
932932
}
933933
}
@@ -936,11 +936,11 @@ impl ITests {
936936
let reader = BufReader::new(controller_stderr);
937937
for line in reader.lines().map_while(Result::ok) {
938938
if print_ctrl_output {
939-
eprintln!("[commissioner_test stderr] {line}");
939+
eprintln!("[commissioner_tests stderr] {line}");
940940
} else {
941941
// The example logs operationally on stderr; in normal
942942
// verbosity we still want it visible on failure.
943-
eprintln!("[commissioner_test] {line}");
943+
eprintln!("[commissioner_tests] {line}");
944944
}
945945
}
946946
});
@@ -951,7 +951,7 @@ impl ITests {
951951
match controller.try_wait() {
952952
Ok(Some(s)) => break s,
953953
Ok(None) if Instant::now() >= deadline => {
954-
warn!("commissioner_test timed out after {test_timeout_secs}s; killing");
954+
warn!("commissioner_tests timed out after {test_timeout_secs}s; killing");
955955
let _ = controller.kill();
956956
let _ = controller.wait();
957957
let _ = app.kill();
@@ -960,13 +960,13 @@ impl ITests {
960960
let _ = stderr_thread.join();
961961
let _ = ctrl_stdout_thread.join();
962962
let _ = ctrl_stderr_thread.join();
963-
anyhow::bail!("commissioner_test timed out");
963+
anyhow::bail!("commissioner_tests timed out");
964964
}
965965
Ok(None) => std::thread::sleep(Duration::from_millis(200)),
966966
Err(e) => {
967967
let _ = app.kill();
968968
let _ = app.wait();
969-
anyhow::bail!("waiting on commissioner_test failed: {e}");
969+
anyhow::bail!("waiting on commissioner_tests failed: {e}");
970970
}
971971
}
972972
};
@@ -983,12 +983,12 @@ impl ITests {
983983
// 7. Assertions: clean exit *and* the success line was emitted.
984984
if !controller_status.success() {
985985
anyhow::bail!(
986-
"commissioner_test exited with {:?} (expected success)",
986+
"commissioner_tests exited with {:?} (expected success)",
987987
controller_status.code(),
988988
);
989989
}
990990
let success_line = success_rx.try_recv().map_err(|_| {
991-
anyhow::anyhow!("commissioner_test did not emit a `commissioner_test: ok ...` line")
991+
anyhow::anyhow!("commissioner_tests did not emit a `commissioner_tests: ok ...` line")
992992
})?;
993993
info!("commissioner suite passed: {success_line}");
994994
// Suppress unused-channel warning on the unused sender.

0 commit comments

Comments
 (0)