cleanup

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: paulr34

src/store/zap/actions.js

@@ -292,8 +292,6 @@ export function updateSelectedEvents(context, selectionContext) {
 export function updateSelectedComponent(context, payload) {
   let op = payload.added ? restApi.uc.componentAdd : restApi.uc.componentRemove
   return axiosRequests.$serverPost(op, payload).then((response) => {
-    // Record the cluster as install-requested so the missing-component warning
-    // gate short-circuits regardless of any contradictory Studio WS updates.
     const list = Array.isArray(response?.data) ? response.data : []
     const anySuccess = list.some((r) => {
       const s = Number(r?.status)

src/store/zap/mutations.js

@@ -987,21 +987,10 @@ export function updateSelectedUcComponentState(state, data) {
 }
 
 /**
- * Apply a Studio WebSocket UC component update.
+ * Merge a Studio component tree snapshot into local state.
  *
- * Studio's "updateComponents" notification carries a full tree snapshot. After
- * a successful install, Studio has been observed to emit a follow-up snapshot
- * that re-marks the just-installed leaf with isSelected:false, which used to
- * make the missing-component warning flicker back.
- *
- * The fix is to treat Studio's WS updates as ADD-ONLY for the local selection
- * set:
- *   - leaves with isSelected:true  -> upserted (Studio can ADD)
- *   - leaves with isSelected:false -> ignored  (Studio cannot remove)
- *   - leaves not mentioned at all  -> left alone (no wipe)
- *
- * ucComponents (the catalog used for labels / metadata) is always merged so
- * we keep accumulating entries.
+ * Add-only for selectedUcComponents: leaves with isSelected:true are upserted,
+ * isSelected:false is ignored. ucComponents (the catalog) is always merged.
  *
  * @param {*} state
  * @param {any[]} treeLeaves Flattened list of leaf nodes from Studio's tree.
@@ -1038,10 +1027,8 @@ export function applyUcComponentUpdate(state, treeLeaves) {
 
 /**
  * Track which cluster ids ZAP has successfully asked Studio to install (or
- * uninstall) components for. The missing-component warning is gated by this
- * list: if ZAP just told Studio to install for a cluster and got a 2xx back,
- * later Studio WebSocket noise cannot flicker the warning back on for that
- * cluster.
+ * uninstall) components for. Consumed by the missing-component warning gate
+ * in common-mixin.js.
  *
  * @param {*} state
  * @param {{ clusterId: any, added: boolean }} payload

src/store/zap/state.js

@@ -193,10 +193,8 @@ export default function () {
     studio: {
       ucComponents: [], // Studio uc component states
       selectedUcComponents: [], // [] of 'studio..' prefixed Studio internal component ids
-      // Cluster ids (the local cluster id, not Studio's component id) that ZAP
-      // has successfully asked Studio to install components for. Used to gate
-      // the missing-component warning so subsequent Studio tree updates can't
-      // flicker it back on for components ZAP itself just installed.
+      // Cluster ids that ZAP has successfully asked Studio to install
+      // components for. Consumed by the missing-component warning gate.
       installRequestedClusterIds: [],
       // a list of dict: { "clusterCode": "$zcl_cluster-$zcl_role", "value": ["$uc_component_id"] }
       zclSdkExtClusterToUcComponentMap: []

src/util/common-mixin.js

@@ -298,11 +298,7 @@ export default {
         )
       }
 
-      // If ZAP has already successfully asked Studio to install for this
-      // cluster, suppress the missing-component warning regardless of how
-      // Studio's tree currently labels things. This is the authoritative
-      // signal -- it bypasses any id-format mismatch between what Studio
-      // echoes back over the WebSocket and what our extension map uses.
+      // If ZAP just installed components for this cluster, skip the check.
       const installRequested =
         this.$store.state.zap.studio.installRequestedClusterIds || []
       if (cluster && installRequested.includes(cluster.id)) {