Skip to content

Commit b189216

Browse files
committed
Made Regex variables global
1 parent d94454d commit b189216

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

pkg/controller/queuejob/queuejob_controller_ex.go

+7-4
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,13 @@ import (
6666
// defaultBackoffTime is the default backoff time in seconds
6767
const defaultBackoffTime = 20
6868

69+
var (
70+
// Regex variables for extracting resource values
71+
cpuRegex = regexp.MustCompile(`cpu (\d+(\.\d+)?)`)
72+
memoryRegex = regexp.MustCompile(`memory (\d+(\.\d+)?)`)
73+
gpuRegex = regexp.MustCompile(`GPU (\d+)`)
74+
)
75+
6976
// XController the AppWrapper Controller type
7077
type XController struct {
7178
// MCAD configuration
@@ -925,10 +932,6 @@ func (qjm *XController) chooseAgent(ctx context.Context, qj *arbv1.AppWrapper) s
925932

926933
// Function for calculating required resources to run AppWrapper and printing a log if there is a required increase for resources.
927934
func calculateRequiredResources(namespace string, appwrapperName string, requestedResources string, totalAvailable string) {
928-
cpuRegex := regexp.MustCompile(`cpu (\d+(\.\d+)?)`)
929-
memoryRegex := regexp.MustCompile(`memory (\d+(\.\d+)?)`)
930-
gpuRegex := regexp.MustCompile(`GPU (\d+)`)
931-
932935
// Requested resources values //
933936
requestedCPU := cpuRegex.FindStringSubmatch(requestedResources)
934937
requestedMemory := memoryRegex.FindStringSubmatch(requestedResources)

0 commit comments

Comments
 (0)