update rest activity defaults

Author: Frank Martinez

activity/rest/README.md

@@ -26,15 +26,16 @@ flogo install github.com/project-flogo/contrib/activity/rest
 | sslConfig     | object | SSL configuration
 
 
-#### *sslConfig* Object:
+#### *sslConfig* Object: 
 | Property      | Type   | Description
 |:---           | :---   | :---     
-| skipVerify    | bool   | Skip SSL validation, defaults to false
-| useSystemCert | bool   | Use the systems root certificate file, defaults to false
+| skipVerify    | bool   | Skip SSL validation, defaults to true
+| useSystemCert | bool   | Use the systems root certificate file, defaults to true
 | caFile        | string | The path to PEM encoded root certificates file
 | certFile      | string | The path to PEM encoded client certificate
 | keyFile       | string | The path to PEM encoded client key
 
+*Note: used if URI is https*
 ### Input:
 | Name        | Type   | Description
 |:---         | :---   | :---     

activity/rest/activity.go

@@ -3,6 +3,7 @@ package rest
 import (
 	"bytes"
 	"encoding/json"
+	"github.com/DataDog/zstd"
 	"io"
 	"io/ioutil"
 	"net/http"
@@ -62,9 +63,23 @@ func New(ctx activity.InitContext) (activity.Activity, error) {
 	if strings.HasPrefix(s.Uri, "https") {
 
 		cfg := &ssl.Config{}
-		err := cfg.FromMap(s.SSLConfig)
-		if err != nil {
-			return nil, err
+
+		if len(s.SSLConfig) != 0 {
+			err := cfg.FromMap(s.SSLConfig)
+			if err != nil {
+				return nil, err
+			}
+
+			if _, set := s.SSLConfig["skipVerify"]; !set {
+				cfg.SkipVerify = true
+			}
+			if _, set := s.SSLConfig["useSystemCert"]; !set {
+				cfg.UseSystemCert = true
+			}
+		} else {
+			//using ssl but not configured, use defaults
+			cfg.SkipVerify = true
+			cfg.UseSystemCert = true
 		}
 
 		tlsConfig, err := ssl.NewClientTLSConfig(cfg)

activity/rest/descriptor.json

@@ -42,13 +42,13 @@
         {
           "name": "skipVerify",
           "type": "boolean",
-          "value": "false",
+          "value": "true",
           "description" : "Skip SSL validation"
         },
         {
           "name": "useSystemCert",
           "type": "boolean",
-          "value": "false",
+          "value": "true",
           "description" : "Use the systems root certificate file"
         },
         {

activity/rest/go.mod

@@ -1,6 +1,7 @@
 module github.com/project-flogo/contrib/activity/rest
 
 require (
+	github.com/DataDog/zstd v1.4.0 // indirect
 	github.com/pkg/errors v0.8.1 // indirect
 	github.com/project-flogo/core v0.9.0
 	github.com/stretchr/testify v1.3.0

activity/rest/go.sum

@@ -1,3 +1,5 @@
+github.com/DataDog/zstd v1.4.0 h1:vhoV+DUHnRZdKW1i5UMjAk2G4JY8wN4ayRfYDNdEhwo=
+github.com/DataDog/zstd v1.4.0/go.mod h1:1jcaCB/ufaK+sKp1NBhlGmpz41jOoPQ35bpF36t7BBo=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/pkg/errors v0.8.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
 github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=