fix shared data delete due to concurrent map writes (#271)

abhijitWakchaure · web-flow · commit 3e823122c05e · 2022-12-08T16:55:17.000+05:30
diff --git a/data/scope.go b/data/scope.go
@@ -93,11 +93,11 @@ func (s *SimpleSyncScope) GetValue(name string) (value interface{}, exists bool)
 
 // Delete implements Scope.GetValue
 func (s *SimpleSyncScope) Delete(name string) {
-	s.mutex.RLock()
+	s.mutex.Lock()
 	if delScope, ok := s.scope.(NeedsDelete); ok {
 		delScope.Delete(name)
 	}
-	s.mutex.RUnlock()
+	s.mutex.Unlock()
 }
 
 // SetValue implements Scope.SetValue

Original file line number	Diff line number	Diff line change
`@@ -93,11 +93,11 @@ func (s *SimpleSyncScope) GetValue(name string) (value interface{}, exists bool)`
`93`	`93`
`94`	`94`	`// Delete implements Scope.GetValue`
`95`	`95`	`func (s *SimpleSyncScope) Delete(name string) {`
`96`		`- s.mutex.RLock()`
	`96`	`+ s.mutex.Lock()`
`97`	`97`	`if delScope, ok := s.scope.(NeedsDelete); ok {`
`98`	`98`	`delScope.Delete(name)`
`99`	`99`	`}`
`100`		`- s.mutex.RUnlock()`
	`100`	`+ s.mutex.Unlock()`
`101`	`101`	`}`
`102`	`102`
`103`	`103`	`// SetValue implements Scope.SetValue`