Skip to content

Commit 57b270c

Browse files
committed
Update per code review comments
1 parent 2356eff commit 57b270c

File tree

2 files changed

+6
-38
lines changed

2 files changed

+6
-38
lines changed

libs/ui-lib/src/components/page/uiVersion/uiVersion.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,11 @@ interface UiVersionProps {
44
appName?: string;
55
}
66

7-
const UiVersion = ({ appName }: UiVersionProps) => {
8-
return <div id={`${appName}:${process.env.BRANCH}:${process.env.COMMITHASH}`} hidden />;
7+
const UiVersion = ({ appName = '@koku-ui' }: UiVersionProps) => {
8+
const branch = process.env.BRANCH ?? 'unknown-branch';
9+
const commithash = process.env.COMMITHASH ?? 'unknown-commithash';
10+
11+
return <div id={`${appName}:${branch}:${commithash}`} hidden />;
912
};
1013

1114
export default UiVersion;

package-lock.json

Lines changed: 1 addition & 36 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)