Removing. disk_size.

Author: bacciotti

Diff for: nise/generators/gcp/compute_engine_generator.py

@@ -126,7 +126,6 @@ def _update_data(self, row):  # noqa: C901
         row["labels"] = self.determine_labels(self.LABELS)
         row["system_labels"] = self.determine_system_labels(sku[3])
         row["price.effective_price"] = choice(self.EFFECTIVE_PRICE)
-        row["disk_size"] = self._generate_disk_size(row["cost"], row["price.effective_price"])
 
         if self.resource_level:
             resource = self._generate_resource(
@@ -190,7 +189,6 @@ def _update_data(self, row):  # noqa: C901
         row["invoice"] = invoice
         effective_price = choice(self.EFFECTIVE_PRICE)
         row["price"] = {"effective_price": effective_price}
-        row["disk_size"] = self._generate_disk_size(row["cost"], row["price"]["effective_price"])
 
         if self.resource_level:
             resource = self._generate_resource()

Diff for: nise/generators/gcp/gcp_generator.py

@@ -57,7 +57,6 @@
     "cost_type",
     "partition_date",
     "price.effective_price",
-    "disk_size",
 )
 
 GCP_RESOURCE_COLUMNS = ("resource.name", "resource.global_name")
@@ -321,14 +320,3 @@ def _generate_hourly_data(self, **kwargs):
             row = self._init_data_row(start, end)
             row = self._update_data(row)
             yield row
-
-    def _generate_disk_size(self, cost, effective_price):
-        """Generate disk size."""
-        hours_in_month = 744
-        disk_size = 0
-
-        if cost and effective_price:
-            rate = float(effective_price) / hours_in_month
-            disk_size = float(cost) / rate
-
-        return disk_size

Diff for: nise/upload.py

@@ -275,7 +275,6 @@ def gcp_bucket_to_dataset(gcp_bucket_name, file_name, dataset_name, table_name,
                 "fields": [{"name": "effective_price", "type": "STRING", "mode": "NULLABLE"}],
                 "mode": "NULLABLE",
             },
-            {"name": "disk_size", "type": "STRING", "mode": "NULLABLE"},
             {
                 "name": "adjustment_info",
                 "type": "RECORD",