Merge pull request #1326 from projectblacklight/cbeer-patch-1

Sentence case field labels

Author: thatbudakguy

config/locales/arclight.en.yml

@@ -75,16 +75,16 @@ en:
           title: Online content
         our_collections: Our Collections
         sections:
-          access_field: Access and Use
+          access_field: Access and use
           background_field: Background
-          collection_context_field: Collection Context
+          collection_context_field: Collection context
           component_field: About this %{level}
-          component_indexed_terms_field: Indexed Terms
-          indexed_terms_field: Indexed Terms
+          component_indexed_terms_field: Indexed terms
+          indexed_terms_field: Indexed terms
           related_field: Related
-          scope_and_arrangement_field: Scope and Arrangement
+          scope_and_arrangement_field: Scope and arrangement
           summary_field: Summary
-        toggle_sidebar: Navigate the Collection
+        toggle_sidebar: Navigate the collection
     within_collection_dropdown:
       all_collections: all collections
       label_html: Search<span class="sr-only visually-hidden"> within</span>

lib/generators/arclight/templates/catalog_controller.rb

@@ -275,8 +275,8 @@ class CatalogController < ApplicationController
     config.add_summary_field 'prefercite_ssm', label: 'Preferred citation', helper_method: :render_html_tags
 
     # Collection Show Page - Background Section
-    config.add_background_field 'scopecontent_ssm', label: 'Scope and Content', helper_method: :render_html_tags
-    config.add_background_field 'bioghist_ssm', label: 'Biographical / Historical', helper_method: :render_html_tags
+    config.add_background_field 'scopecontent_ssm', label: 'Scope and content', helper_method: :render_html_tags
+    config.add_background_field 'bioghist_ssm', label: 'Biographical / historical', helper_method: :render_html_tags
     config.add_background_field 'acqinfo_ssim', label: 'Acquisition information', helper_method: :render_html_tags
     config.add_background_field 'appraisal_ssm', label: 'Appraisal information', helper_method: :render_html_tags
     config.add_background_field 'custodhist_ssm', label: 'Custodial history', helper_method: :render_html_tags
@@ -327,7 +327,7 @@ class CatalogController < ApplicationController
     }
     config.add_component_field 'abstract_ssm', label: 'Abstract', helper_method: :render_html_tags
     config.add_component_field 'extent_ssm', label: 'Extent'
-    config.add_component_field 'scopecontent_ssm', label: 'Scope and Content', helper_method: :render_html_tags
+    config.add_component_field 'scopecontent_ssm', label: 'Scope and content', helper_method: :render_html_tags
     config.add_component_field 'acqinfo_ssim', label: 'Acquisition information', helper_method: :render_html_tags
     config.add_component_field 'appraisal_ssm', label: 'Appraisal information', helper_method: :render_html_tags
     config.add_component_field 'custodhist_ssm', label: 'Custodial history', helper_method: :render_html_tags
@@ -362,13 +362,13 @@ class CatalogController < ApplicationController
 
     # Collection Show Page Access Tab - Terms and Conditions Section
     config.add_terms_field 'accessrestrict_ssm', label: 'Restrictions', helper_method: :render_html_tags
-    config.add_terms_field 'userestrict_ssm', label: 'Terms of Access', helper_method: :render_html_tags
+    config.add_terms_field 'userestrict_ssm', label: 'Terms of access', helper_method: :render_html_tags
 
     # Component Show Page Access Tab - Terms and Condition Section
     config.add_component_terms_field 'accessrestrict_ssm', label: 'Restrictions', helper_method: :render_html_tags
-    config.add_component_terms_field 'userestrict_ssm', label: 'Terms of Access', helper_method: :render_html_tags
-    config.add_component_terms_field 'parent_access_restrict_ssm', label: 'Parent Restrictions', helper_method: :render_html_tags
-    config.add_component_terms_field 'parent_access_terms_ssm', label: 'Parent Terms of Access', helper_method: :render_html_tags
+    config.add_component_terms_field 'userestrict_ssm', label: 'Terms of access', helper_method: :render_html_tags
+    config.add_component_terms_field 'parent_access_restrict_ssm', label: 'Parent restrictions', helper_method: :render_html_tags
+    config.add_component_terms_field 'parent_access_terms_ssm', label: 'Parent terms of access', helper_method: :render_html_tags
 
     # Collection and Component Show Page Access Tab - In Person Section
     config.add_in_person_field 'repository_location', values: ->(_, document, _) { document.repository_config }, label: 'Location of this collection', component: Arclight::RepositoryLocationComponent

spec/components/arclight/collection_sidebar_component_spec.rb

@@ -21,7 +21,7 @@
     expect(page).to have_link 'Summary'
     expect(page).to have_link 'Background'
     expect(page).to have_link 'Related'
-    expect(page).to have_link 'Indexed Terms'
-    expect(page).to have_link 'Access and Use'
+    expect(page).to have_link 'Indexed terms'
+    expect(page).to have_link 'Access and use'
   end
 end

spec/features/collection_page_spec.rb

@@ -75,10 +75,10 @@
 
     it 'background has configured metadata' do
       within '#background' do
-        expect(page).to have_css('dt', text: 'Scope and Content')
+        expect(page).to have_css('dt', text: 'Scope and content')
         expect(page).to have_css('dd', text: /^Correspondence, documents, records, photos/)
 
-        expect(page).to have_css('dt', text: 'Biographical / Historical')
+        expect(page).to have_css('dt', text: 'Biographical / historical')
         expect(page).to have_css('dd', text: /^Alpha Omega Alpha Honor Medical Society was founded/)
 
         expect(page).to have_css('dt', text: 'Acquisition information')
@@ -165,7 +165,7 @@
         expect(page).to have_link 'Summary', href: /#summary/
         expect(page).to have_link 'Background', href: /#background/
         expect(page).to have_link 'Related', href: /#related/
-        expect(page).to have_link 'Indexed Terms', href: /#indexed-terms/
+        expect(page).to have_link 'Indexed terms', href: /#indexed-terms/
       end
     end
 

spec/features/component_page_spec.rb

@@ -214,9 +214,9 @@
       expect(page).to have_css 'dt', text: 'Location of this collection:'
       expect(page).to have_css 'dd', text: 'Building 38, Room 1E-21'
 
-      expect(page).to have_css 'dt', text: 'Parent Restrictions:'
+      expect(page).to have_css 'dt', text: 'Parent restrictions:'
       expect(page).to have_css 'dd', text: /^RESTRICTED: Access to these folders requires prior written approval./
-      expect(page).to have_css 'dt', text: 'Terms of Access:'
+      expect(page).to have_css 'dt', text: 'Parent terms of access:'
       expect(page).to have_css 'dd', text: /^Copyright was transferred to the public domain./
 
       expect(page).to have_css 'dt', text: 'Contact:'