Skip to content

Commit 481b57f

Browse files
authored
Merge pull request #63 from projectblacklight/rails8
Test with rails 8 and ruby 3.4
2 parents 69bab48 + 023c37d commit 481b57f

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

.github/workflows/main.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,14 @@ jobs:
99
strategy:
1010
fail-fast: false
1111
matrix:
12-
ruby_version: ['3.3.8', '3.2.8']
13-
rails_version: ['7.2.2.1', '7.1.5.1']
12+
ruby_version: ['3.4.4', '3.3.8', '3.2.8']
13+
rails_version: ['8.0.1', '7.2.2.1', '7.1.5.1']
1414

1515
runs-on: ubuntu-latest
1616
name: ruby ${{ matrix.ruby_version }} | rails ${{ matrix.rails_version }}
1717
env:
1818
RAILS_VERSION: ${{ matrix.rails_version }}
19-
ENGINE_CART_RAILS_OPTIONS: "--skip-git --skip-listen --skip-spring --skip-keeps --skip-kamal --skip-solid --skip-coffee --skip-test"
19+
ENGINE_CART_RAILS_OPTIONS: "--skip-git --skip-listen --skip-spring --skip-keeps --skip-kamal --skip-solid --skip-coffee --skip-test --skip-assets"
2020
steps:
2121
- name: Checkout code
2222
uses: actions/checkout@v4

blacklight-access_controls.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ Gem::Specification.new do |gem|
3131

3232
gem.add_development_dependency 'database_cleaner'
3333
gem.add_development_dependency 'engine_cart', '~> 2.2'
34-
gem.add_development_dependency 'factory_bot_rails', '~> 4.8'
34+
gem.add_development_dependency 'factory_bot_rails', '>= 4.8'
3535
gem.add_development_dependency 'rake', '~> 12.3'
3636
gem.add_development_dependency 'rspec', '~> 3.1'
3737
gem.add_development_dependency 'rubocop', '~> 1.29'

spec/test_app_templates/lib/generators/test_app_generator.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ class TestAppGenerator < Rails::Generators::Base
1111

1212
def generate_blacklight
1313
say_status('status', 'GENERATING BLACKLIGHT', :yellow)
14-
generate 'blacklight:install', '--devise'
14+
generate 'blacklight:install', '--devise --skip-assets'
1515
end
1616

1717
def configure_blacklight

0 commit comments

Comments
 (0)