Merge pull request #3635 from projectblacklight/remove-legacy-request-handler

Remove legacy document_solr_request_handler

Author: jcoyne

lib/blacklight/configuration.rb

@@ -66,9 +66,6 @@ def initialized_default_configuration?
 
       # === Single document request configuration
 
-      # @!attribute document_solr_request_handler
-      # @return [String] The solr request handler to use when requesting only a single document
-      property :document_solr_request_handler, default: nil
       # @!attribute document_solr_path
       # @since v5.2.0
       # @return [String] The url path (relative to the solr base url) to use when requesting only a single document

lib/blacklight/solr/repository.rb

@@ -8,7 +8,6 @@ class Repository < Blacklight::AbstractRepository
     # @param [Hash] params additional solr query parameters
     def find id, params = {}
       doc_params = params.reverse_merge(blacklight_config.default_document_solr_params)
-                         .reverse_merge(qt: blacklight_config.document_solr_request_handler)
                          .merge(blacklight_config.document_unique_id_param => id)
 
       solr_response = send_and_receive blacklight_config.document_solr_path || blacklight_config.solr_path, doc_params

spec/models/blacklight/solr/repository_spec.rb

@@ -44,26 +44,6 @@
       end
     end
 
-    context "with legacy request handler-based configuration" do
-      before do
-        blacklight_config.document_solr_path = 'select'
-        blacklight_config.document_unique_id_param = :id
-      end
-
-      it "uses the provided :qt param" do
-        blacklight_config.document_solr_request_handler = 'xyz'
-        allow(subject.connection).to receive(:send_and_receive).with('select', hash_including(params: { id: '123', qt: 'abc' })).and_return(mock_response)
-        expect(subject.find("123", qt: 'abc')).to be_a Blacklight::Solr::Response
-      end
-
-      it "uses the :qt parameter from the default_document_solr_params" do
-        blacklight_config.default_document_solr_params[:qt] = 'abc'
-        blacklight_config.document_solr_request_handler = 'xyz'
-        allow(subject.connection).to receive(:send_and_receive).with('select', hash_including(params: { id: '123', qt: 'abc' })).and_return(mock_response)
-        expect(subject.find("123")).to be_a Blacklight::Solr::Response
-      end
-    end
-
     it "preserves the class of the incoming params" do
       doc_params = ActiveSupport::HashWithIndifferentAccess.new
       allow(subject.connection).to receive(:send_and_receive).with('get', anything).and_return(mock_response)