Merge pull request #3598 from projectblacklight/rubocop

Add new rubocops and regnerate todo

Author: jcoyne

.rubocop.yml

@@ -1,4 +1,4 @@
-require:
+plugins:
   - rubocop-capybara
   - rubocop-rspec
   - rubocop-rspec_rails
@@ -631,3 +631,25 @@ Rails/MultipleRoutePaths: # new in 2.29
   Enabled: true
 Rails/StrongParametersExpect: # new in 2.29
   Enabled: true
+Lint/CopDirectiveSyntax: # new in 1.72
+  Enabled: true
+Lint/RedundantTypeConversion: # new in 1.72
+  Enabled: true
+Lint/SuppressedExceptionInNumberConversion: # new in 1.72
+  Enabled: true
+Lint/UselessConstantScoping: # new in 1.72
+  Enabled: true
+Style/ComparableBetween: # new in 1.74
+  Enabled: true
+Style/HashFetchChain: # new in 1.75
+  Enabled: true
+Style/ItBlockParameter: # new in 1.75
+  Enabled: true
+Style/RedundantFormat: # new in 1.72
+  Enabled: true
+Capybara/FindAllFirst: # new in 2.22
+  Enabled: true
+Capybara/NegationMatcherAfterVisit: # new in 2.22
+  Enabled: true
+RSpec/IncludeExamples: # new in 3.6
+  Enabled: true

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2024-09-03 14:22:19 UTC using RuboCop version 1.66.0.
+# on 2025-05-09 14:34:28 UTC using RuboCop version 1.75.5.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -12,6 +12,16 @@ Capybara/CurrentPathExpectation:
   Exclude:
     - 'spec/features/alternate_controller_spec.rb'
 
+# Offense count: 7
+Capybara/NegationMatcherAfterVisit:
+  Exclude:
+    - 'spec/features/bookmarks_spec.rb'
+    - 'spec/features/facets_spec.rb'
+    - 'spec/features/modal_spec.rb'
+    - 'spec/features/record_view_spec.rb'
+    - 'spec/features/search_context_spec.rb'
+    - 'spec/features/sitelinks_search_box_spec.rb'
+
 # Offense count: 13
 Capybara/VisibilityMatcher:
   Exclude:
@@ -35,7 +45,7 @@ Lint/AmbiguousOperator:
     - 'spec/models/blacklight/facet_paginator_spec.rb'
     - 'spec/services/blacklight/search_service_spec.rb'
 
-# Offense count: 45
+# Offense count: 43
 # This cop supports safe autocorrection (--autocorrect).
 Lint/AmbiguousRegexpLiteral:
   Exclude:
@@ -45,7 +55,6 @@ Lint/AmbiguousRegexpLiteral:
     - 'spec/helpers/catalog_helper_spec.rb'
     - 'spec/models/record_mailer_spec.rb'
     - 'spec/views/catalog/_document.html.erb_spec.rb'
-    - 'spec/views/catalog/_search_header.erb_spec.rb'
     - 'spec/views/catalog/_sort_and_per_page.html.erb_spec.rb'
     - 'spec/views/catalog/index.html.erb_spec.rb'
     - 'spec/views/catalog/show.html.erb_spec.rb'
@@ -75,7 +84,7 @@ Lint/EmptyBlock:
     - 'app/controllers/concerns/blacklight/bookmarks.rb'
     - 'lib/blacklight/solr/search_builder_behavior.rb'
 
-# Offense count: 48
+# Offense count: 50
 # Configuration parameters: AllowedParentClasses.
 Lint/MissingSuper:
   Enabled: false
@@ -90,12 +99,7 @@ Lint/ParenthesesAsGroupedExpression:
     - 'spec/features/search_spec.rb'
     - 'spec/models/blacklight/solr/repository_spec.rb'
 
-# Offense count: 2
-Lint/ShadowingOuterLocalVariable:
-  Exclude:
-    - 'spec/models/blacklight/configuration_spec.rb'
-
-# Offense count: 83
+# Offense count: 81
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
 Metrics/AbcSize:
   Max: 46
@@ -106,27 +110,27 @@ Metrics/AbcSize:
 Metrics/BlockLength:
   Max: 26
 
-# Offense count: 42
+# Offense count: 40
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/CyclomaticComplexity:
-  Max: 14
+  Max: 13
 
-# Offense count: 78
+# Offense count: 77
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
   Max: 27
 
-# Offense count: 4
+# Offense count: 3
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ModuleLength:
-  Max: 124
+  Max: 114
 
-# Offense count: 8
+# Offense count: 7
 # Configuration parameters: CountKeywordArgs, MaxOptionalParameters.
 Metrics/ParameterLists:
   Max: 6
 
-# Offense count: 36
+# Offense count: 33
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/PerceivedComplexity:
   Max: 14
@@ -155,7 +159,7 @@ Naming/MethodParameterName:
 # Offense count: 9
 # Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
 # SupportedStyles: snake_case, normalcase, non_integer
-# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
+# AllowedIdentifiers: TLS1_1, TLS1_2, capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
 Naming/VariableNumber:
   Exclude:
     - 'spec/lib/blacklight/search_state_spec.rb'
@@ -175,7 +179,7 @@ RSpec/BeforeAfterAll:
 RSpec/ContextWording:
   Enabled: false
 
-# Offense count: 138
+# Offense count: 146
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
   Max: 33
@@ -226,7 +230,7 @@ RSpec/MessageChain:
     - 'spec/presenters/blacklight/field_presenter_spec.rb'
     - 'spec/views/shared/_user_util_links.html.erb_spec.rb'
 
-# Offense count: 28
+# Offense count: 27
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: have_received, receive
 RSpec/MessageSpies:
@@ -240,22 +244,22 @@ RSpec/MessageSpies:
     - 'spec/models/blacklight/suggest_search_spec.rb'
     - 'spec/presenters/blacklight/field_presenter_spec.rb'
 
-# Offense count: 390
+# Offense count: 401
 RSpec/MultipleExpectations:
   Max: 16
 
-# Offense count: 292
+# Offense count: 294
 # Configuration parameters: AllowSubject.
 RSpec/MultipleMemoizedHelpers:
   Max: 14
 
-# Offense count: 399
+# Offense count: 431
 # Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
 # SupportedStyles: always, named_only
 RSpec/NamedSubject:
   Enabled: false
 
-# Offense count: 60
+# Offense count: 62
 # Configuration parameters: AllowedGroups.
 RSpec/NestedGroups:
   Max: 5
@@ -283,7 +287,7 @@ RSpec/ScatteredLet:
   Exclude:
     - 'spec/views/catalog/index.atom.builder_spec.rb'
 
-# Offense count: 20
+# Offense count: 19
 RSpec/StubbedMock:
   Exclude:
     - 'spec/controllers/catalog_controller_spec.rb'
@@ -309,7 +313,7 @@ RSpec/SubjectStub:
     - 'spec/presenters/blacklight/document_presenter_spec.rb'
     - 'spec/services/blacklight/search_service_spec.rb'
 
-# Offense count: 80
+# Offense count: 79
 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:
   Enabled: false
@@ -322,7 +326,7 @@ Rails/Date:
   Exclude:
     - 'spec/models/search_spec.rb'
 
-# Offense count: 20
+# Offense count: 17
 # Configuration parameters: Include.
 # Include: app/helpers/**/*.rb
 Rails/HelperInstanceVariable:
@@ -345,7 +349,7 @@ Rails/OutputSafety:
   Exclude:
     - 'app/presenters/blacklight/rendering/join.rb'
 
-# Offense count: 14
+# Offense count: 15
 Security/Eval:
   Exclude:
     - 'spec/models/blacklight/solr/response_spec.rb'
@@ -377,8 +381,10 @@ Style/BlockDelimiters:
 
 # Offense count: 52
 # This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle.
+# Configuration parameters: EnforcedStyle, EnforcedStyleForClasses, EnforcedStyleForModules.
 # SupportedStyles: nested, compact
+# SupportedStylesForClasses: , nested, compact
+# SupportedStylesForModules: , nested, compact
 Style/ClassAndModuleChildren:
   Enabled: false
 
@@ -403,7 +409,7 @@ Style/DocumentDynamicEvalDefinition:
     - 'app/builders/blacklight/action_builder.rb'
     - 'lib/blacklight/configuration/fields.rb'
 
-# Offense count: 133
+# Offense count: 131
 # Configuration parameters: AllowedConstants.
 Style/Documentation:
   Enabled: false
@@ -422,9 +428,9 @@ Style/ExpandPathArguments:
     - 'lib/generators/blacklight/test_support_generator.rb'
     - 'lib/generators/blacklight/user_generator.rb'
 
-# Offense count: 16
+# Offense count: 17
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: MaxUnannotatedPlaceholdersAllowed, AllowedMethods, AllowedPatterns.
+# Configuration parameters: MaxUnannotatedPlaceholdersAllowed, Mode, AllowedMethods, AllowedPatterns.
 # SupportedStyles: annotated, template, unannotated
 # AllowedMethods: redirect
 Style/FormatStringToken:
@@ -441,18 +447,17 @@ Style/GuardClause:
     - 'app/helpers/blacklight/catalog_helper_behavior.rb'
     - 'lib/blacklight/solr/search_builder_behavior.rb'
 
-# Offense count: 29
+# Offense count: 30
 # This cop supports safe autocorrection (--autocorrect).
 Style/IfUnlessModifier:
   Enabled: false
 
-# Offense count: 6
+# Offense count: 4
 # This cop supports safe autocorrection (--autocorrect).
 Style/MultilineIfModifier:
   Exclude:
     - 'app/views/catalog/index.atom.builder'
     - 'lib/blacklight/solr/response/facets.rb'
-    - 'lib/blacklight/solr/search_builder_behavior.rb'
 
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
@@ -461,15 +466,7 @@ Style/MultipleComparison:
   Exclude:
     - 'lib/blacklight/configuration/context.rb'
 
-# Offense count: 2
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: literals, strict
-Style/MutableConstant:
-  Exclude:
-    - 'lib/blacklight/solr/request.rb'
-
-# Offense count: 9
+# Offense count: 8
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle, AllowedMethods, AllowedPatterns.
 # SupportedStyles: predicate, comparison
@@ -501,13 +498,12 @@ Style/ParenthesesAroundCondition:
   Exclude:
     - 'app/views/catalog/_document.atom.builder'
 
-# Offense count: 3
+# Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:
   Exclude:
     - 'lib/blacklight/engine.rb'
-    - 'lib/blacklight/solr/request.rb'
 
 # Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
@@ -541,7 +537,7 @@ Style/SoleNestedConditional:
   Exclude:
     - 'app/controllers/concerns/blacklight/controller.rb'
 
-# Offense count: 32
+# Offense count: 31
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: MinSize.
 # SupportedStyles: percent, brackets