Bookmarks don't display correctly when uuid of bookmarked document is a negative number

[jogilder]

Our documents have randomly generated UUIDs. All the UUIDs are large integers with the majority of these being negative numbers. The search builder that passes the query to solr does not put speech marks around the uuid. Any query passed to solr must have the string in speech marks, eg UUID:"-6604297317300560302" This means that our bookmarks only displays correctly if all of the documents that are bookmarked have positive UUIDs.

I think this is where the code needs altering but I can't be sure exactly what needs doing and if this won't have a knock on impact elsewhere.

https://github.com/projectblacklight/blacklight/blob/acf1bcc0e779b4dc83110b007f49bea20759728b/lib/blacklight/solr/search_builder_behavior.rb

[cbeer]

Thanks for the report. We build the lucene query used for the bookmarks page here: https://github.com/projectblacklight/blacklight/blob/master/lib/blacklight/solr/search_builder_behavior.rb#L72

I took a quick look into this, and it seems like Solr translates "id:(-123)" into "-id:123". We pass the values through an escaping function (https://github.com/projectblacklight/blacklight/blob/master/lib/blacklight/solr/search_builder_behavior.rb#L256), maybe it will be sufficient for now to ensure we also aggressively escape values with a leading -?

Ideally, we might consider updating https://github.com/projectblacklight/blacklight/blob/master/lib/blacklight/solr/search_builder_behavior.rb#L72 to use the !terms query parser, although with quick testing, it wasn't clear how we can escape the separator character in values.

[jogilder]

OK, assuming that escaping works we would be happy with that. Many thanks.

[jogilder]

Hi, is there an eta for when this might be fixed? Many thanks.

[atz]

@projectblacklight/contributors needs milestone