Skip to content

Commit 54516e2

Browse files
hanthorclaude
andcommitted
fix(ci): don't --rm the boot-test VM — it races serial.log capture
CodeRabbit review: with --rm, a VM that exits early (the exact failure M0 exists to diagnose) is autoremoved before cleanup() reads podman logs, silently losing the serial console. cleanup() already does the explicit rm -f. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018bGymcRkVtV7DPToWDjZyZ
1 parent ac92100 commit 54516e2

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

.github/workflows/boot-test-aarch64.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,10 @@ jobs:
134134
trap cleanup EXIT
135135
136136
echo "==> Launching ephemeral VM from ${IMAGE}..."
137-
sudo "$HOME/.cargo/bin/bcvk" ephemeral run -d --rm -K --console \
137+
# No --rm: if the VM exits early (the exact failure we want to
138+
# diagnose), autoremoval would race away the container before
139+
# cleanup() captures serial.log. cleanup() does the rm -f.
140+
sudo "$HOME/.cargo/bin/bcvk" ephemeral run -d -K --console \
138141
--memory 8192M --vcpus 4 --name "$VM_NAME" "${IMAGE}"
139142
140143
echo "==> Waiting for SSH (timeout ${SSH_TIMEOUT}s)..."

0 commit comments

Comments
 (0)