Finding
PR #1136 (fix(ujust): harden confirm and verify issue recipes) adds security-sensitive recipe logic to files/just-overrides/default.just:
quote() usage for argument escaping
- Non-tty/stdin detection and handling
sudo -n (non-interactive sudo) behavior
- Clipboard integration paths
This logic has no automated tests. Silent failures or regressions (e.g., command injection via unquoted arguments, broken non-interactive mode) would only surface at runtime.
Recommendation
Add BATS unit tests that:
- Call the hardened
confirm and verify-issue recipes with mock inputs
- Verify that special characters in arguments are properly quoted
- Verify that non-tty mode (e.g.,
echo "y" | just confirm) exits correctly
- Verify sudo permission checks don't fail silently
Priority
- Impact: high (security-sensitive ujust recipes used interactively)
- Effort: medium (requires just recipe test harness)
Filed by quality agent (hold-gated mode)
Finding
PR #1136 (
fix(ujust): harden confirm and verify issue recipes) adds security-sensitive recipe logic tofiles/just-overrides/default.just:quote()usage for argument escapingsudo -n(non-interactive sudo) behaviorThis logic has no automated tests. Silent failures or regressions (e.g., command injection via unquoted arguments, broken non-interactive mode) would only surface at runtime.
Recommendation
Add BATS unit tests that:
confirmandverify-issuerecipes with mock inputsecho "y" | just confirm) exits correctlyPriority
Filed by quality agent (hold-gated mode)