fix: add x-launch-check support and --no-sandbox for goose electron launch

Electron apps crash with FATAL when run as root without --no-sandbox.
Add x-launch-check field support to the launch check step so per-app
args can be specified, and set x-launch-check: [--no-sandbox] for goose.

Assisted-by: Claude Sonnet 4.6 via OpenCode

Author: castrojo

.github/workflows/build.yml

@@ -1085,16 +1085,24 @@ jobs:
         if: steps.arch-check.outputs.skip != 'true'
         run: |
           APP_ID="${{ steps.app-meta.outputs.app_id }}"
+          # Read optional per-app launch args (e.g. --no-sandbox for Electron root runs)
+          LAUNCH_ARGS=""
+          if [[ -f "flatpaks/${{ matrix.app }}/release.yaml" ]]; then
+            LAUNCH_ARGS=$(yq -r '(.["x-launch-check"] // []) | join(" ")' \
+              "flatpaks/${{ matrix.app }}/release.yaml")
+          elif [[ -f "flatpaks/${{ matrix.app }}/manifest.yaml" ]]; then
+            LAUNCH_ARGS=$(yq -r '(.["x-launch-check"] // []) | join(" ")' \
+              "flatpaks/${{ matrix.app }}/manifest.yaml")
+          fi
           set +e
-          timeout 5 flatpak run "${APP_ID}"
+          # shellcheck disable=SC2086
+          timeout 5 flatpak run "${APP_ID}" ${LAUNCH_ARGS}
           EXIT=$?
           set -e
           if [[ "${EXIT}" -eq 0 ]]; then
             echo "==> PASS: ${APP_ID} ran and exited cleanly (exit 0)"
           elif [[ "${EXIT}" -eq 124 ]]; then
             echo "==> PASS: ${APP_ID} launched successfully (exit 124 — timed out, app did not self-exit)"
-            echo "    HINT: consider adding x-launch-check: [--version] to the app manifest for"
-            echo "    a cleaner headless smoke test (e.g. 'flatpak run ${APP_ID} --version')."
           else
             echo "ERROR: ${APP_ID} launch failed (exit ${EXIT})" >&2
             exit 1

flatpaks/goose/release.yaml

@@ -8,4 +8,5 @@ title: Goose
 description: Goose AI agent - Flatpak repack
 license: Apache-2.0
 chunkah-max-layers: "16"
+x-launch-check: ["--no-sandbox"]