Skip to content

Commit 469346d

Browse files
castrojoCopilot
andcommitted
fix(rancher-desktop): fix builddir lint errors
Three issues from the builddir lint step: - appstream-missing-developer-name: add <developer> tag to metainfo.xml - appstream-failed-validation (desktop-app-launchable-missing): add <launchable> tag to metainfo.xml - elf-arch-multiple-found: upstream zip bundles both x86_64 and aarch64 native Node modules; add to exceptions.json Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent c8fd139 commit 469346d

File tree

3 files changed

+17
-1
lines changed

3 files changed

+17
-1
lines changed

flatpaks/rancher-desktop/GOTCHAS.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,3 +59,16 @@ step validates that icons in `hicolor/512x512/` are ≤512×512 and rejects the
5959

6060
Fix: use `python3` + GdkPixbuf (available in GNOME SDK 49) to resize the icon to 512×512 before
6161
installing it. Do **not** use `install -Dm644` directly — that copies the oversized file as-is.
62+
63+
## elf-arch-multiple-found lint exception
64+
The upstream zip bundles native Node modules for both x86_64 and aarch64 (e.g.
65+
`posix-node/dist/aarch64-linux-gnu.node` alongside `x86_64-linux-gnu.node`).
66+
flatpak-builder-lint flags this as `elf-arch-multiple-found`. It is intentional and
67+
structural — the upstream ships a fat zip with multi-arch native modules. Added to
68+
`exceptions.json`.
69+
70+
## appstream-missing-developer-name / appstream-failed-validation fixes
71+
The upstream metainfo.xml does not include `<developer>` or `<launchable>` tags.
72+
Both have been added to `io.rancherdesktop.RancherDesktop.metainfo.xml`:
73+
- `<developer><name>SUSE LLC</name></developer>`
74+
- `<launchable type="desktop-id">io.rancherdesktop.RancherDesktop.desktop</launchable>`

flatpaks/rancher-desktop/exceptions.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
"metainfo-missing-screenshots",
66
"finish-args-home-filesystem-access",
77
"finish-args-flatpak-spawn-access",
8-
"finish-args-host-os-ro-filesystem-access"
8+
"finish-args-host-os-ro-filesystem-access",
9+
"elf-arch-multiple-found"
910
]
1011
}

flatpaks/rancher-desktop/io.rancherdesktop.RancherDesktop.metainfo.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
<url type="bugtracker">https://github.com/rancher-sandbox/rancher-desktop/issues</url>
2121
<metadata_license>MIT</metadata_license>
2222
<project_license>Apache-2.0</project_license>
23+
<developer><name>SUSE LLC</name></developer>
24+
<launchable type="desktop-id">io.rancherdesktop.RancherDesktop.desktop</launchable>
2325
<categories>
2426
<category>Development</category>
2527
<category>Utility</category>

0 commit comments

Comments
 (0)