Skip to content

Commit 6a0876c

Browse files
committed
refactor: remove usage of useCaluma in route
1 parent c2fa4da commit 6a0876c

File tree

25 files changed

+202
-169
lines changed

25 files changed

+202
-169
lines changed

ember/.eslintignore

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,3 @@
1818
/.node_modules.ember-try/
1919
/bower.json.ember-try
2020
/package.json.ember-try
21-
22-
# mirage
23-
/mirage/mirage
Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,20 @@
11
import Controller from "@ember/controller";
2+
import getCaseQuery from "caluma-portal-demo/gql/queries/get-case";
3+
import { queryManager } from "ember-apollo-client";
4+
import { dropTask, lastValue } from "ember-concurrency";
25

36
export default class CasesDetailController extends Controller {
4-
get case() {
5-
return this.model.value[0];
7+
@queryManager apollo;
8+
9+
@lastValue("getCase") case;
10+
@dropTask
11+
*getCase() {
12+
return (yield this.apollo.query(
13+
{
14+
query: getCaseQuery,
15+
variables: { filter: [{ id: this.model }] },
16+
},
17+
"allCases.edges"
18+
)).map(({ node }) => node)[0];
619
}
720
}
Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
import Controller from "@ember/controller";
1+
import Controller, { inject as controller } from "@ember/controller";
22

33
export default class CasesDetailEditController extends Controller {
4-
get case() {
5-
return this.model.value[0];
6-
}
4+
@controller("cases.detail") parent;
75
}
Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
11
import CasesDetailRoute from "caluma-portal-demo/cases/detail/index/route";
22

3-
export default class CasesDetailEditRoute extends CasesDetailRoute {
4-
model() {
5-
return this.modelFor("cases.detail");
6-
}
7-
}
3+
export default class CasesDetailEditRoute extends CasesDetailRoute {}
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
{{#if @model}}
2-
<CfContent @documentId={{this.case.document.id}} />
1+
{{#if this.parent.case}}
2+
<CfContent @documentId={{this.parent.case.document.id}} />
33
{{/if}}

ember/app/cases/detail/index/controller.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import Controller from "@ember/controller";
1+
import Controller, { inject as controller } from "@ember/controller";
22
import { inject as service } from "@ember/service";
33
import cancelCaseMutation from "caluma-portal-demo/gql/mutations/cancel-case";
44
import { queryManager } from "ember-apollo-client";
@@ -7,16 +7,13 @@ import { dropTask } from "ember-concurrency";
77
export default class CasesDetailIndexController extends Controller {
88
@service router;
99
@queryManager apollo;
10-
11-
get case() {
12-
return this.model.value[0];
13-
}
10+
@controller("cases.detail") parent;
1411

1512
@dropTask
1613
*closeCase() {
1714
yield this.apollo.mutate({
1815
mutation: cancelCaseMutation,
19-
variables: { case: this.case.id },
16+
variables: { case: this.parent.case.id },
2017
});
2118
this.router.transitionTo("cases.index");
2219
}
Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
11
import Route from "@ember/routing/route";
22

3-
export default class CasesDetailRoute extends Route {
4-
model() {
5-
return this.modelFor("cases.detail");
6-
}
7-
}
3+
export default class CasesDetailRoute extends Route {}

ember/app/cases/detail/index/template.hbs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@
1212
{{t "cases.status"}}
1313
</th>
1414
<td class="uk-width-1-3">
15-
<CaseStateLabel @state={{this.case.raw.status}} @iconPosition="right" />
15+
<CaseStateLabel @state={{this.parent.case.status}} @iconPosition="right" />
1616
</td>
1717
<th class="uk-text-bold uk-width-1-6">
1818
{{t "cases.description"}}
1919
</th>
2020
<td class="uk-width-1-3">
21-
{{or this.case.form.description "-"}}
21+
{{or this.parent.case.form.description "-"}}
2222
</td>
2323
</tr>
2424
<tr>
@@ -28,8 +28,8 @@
2828
<td class="uk-width-1-3">
2929
{{
3030
if
31-
this.case.createdAt
32-
(moment-format this.case.createdAt "DD.MM.YYYY")
31+
this.parent.case.createdAt
32+
(moment-format this.parent.case.createdAt "DD.MM.YYYY")
3333
"-"
3434
}}
3535
</td>
@@ -39,8 +39,8 @@
3939
<td class="uk-width-1-3">
4040
{{
4141
if
42-
this.case.modifiedAt
43-
(moment-format this.case.modifiedAt "DD.MM.YYYY")
42+
this.parent.case.modifiedAt
43+
(moment-format this.parent.case.modifiedAt "DD.MM.YYYY")
4444
"-"
4545
}}
4646
</td>
@@ -76,7 +76,7 @@
7676
{{t "cases.deleteText"}}
7777
</p>
7878
<UkButton
79-
@onClick={{perform this.closeCase this.case}}
79+
@onClick={{perform this.closeCase}}
8080
@disabled={{this.closeCase.isRunning}}
8181
@loading={{this.closeCase.isRunning}}
8282
>

ember/app/cases/detail/route.js

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
import Route from "@ember/routing/route";
2-
import { useCalumaQuery } from "@projectcaluma/ember-core/caluma-query";
3-
import { allCases } from "@projectcaluma/ember-core/caluma-query/queries";
2+
43
export default class CasesDetailRoute extends Route {
54
model({ case_id }) {
6-
const caseQuery = useCalumaQuery(this, allCases, () => ({
7-
options: { pageSize: 1 },
8-
filter: [{ id: case_id }],
9-
}));
5+
return case_id;
6+
}
107

11-
return caseQuery;
8+
setupController(controller, post) {
9+
super.setupController(controller, post);
10+
controller.getCase.perform();
1211
}
1312
}

ember/app/cases/detail/template.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{{#if @model.isLoading}}
1+
{{#if this.getCase.isRunning}}
22
<div class="uk-text-center uk-padding">
33
<UkSpinner @ratio={{2}} />
44
</div>

0 commit comments

Comments
 (0)